fix(acp): Allow multiple Ctrl-C calls to exit program#82
Merged
Conversation
Previously, Op::Shutdown was silently ignored by the ACP backend, causing the double Ctrl-C quit mechanism to fail. When a user pressed Ctrl-C at idle state, the TUI would send Op::Shutdown but the ACP backend would ignore it, so no ShutdownComplete event was sent back and the program would never exit. This change properly handles Op::Shutdown by: 1. Canceling any in-progress ACP session 2. Sending a ShutdownComplete event back to the TUI This allows the TUI to receive the shutdown signal and exit properly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, Op::Shutdown was silently ignored by the ACP backend, causing the double Ctrl-C quit mechanism to fail. When a user pressed Ctrl-C at idle state, the TUI would send Op::Shutdown but the ACP backend would ignore it, so no ShutdownComplete event was sent back and the program would never exit.
This change properly handles Op::Shutdown by:
This allows the TUI to receive the shutdown signal and exit properly.