Skip to content

Fix broken npm install (missing dist) + add CI#2

Merged
theahura merged 1 commit intomainfrom
auto/nori-slack-command-not-working-20260424-212148
Apr 24, 2026
Merged

Fix broken npm install (missing dist) + add CI#2
theahura merged 1 commit intomainfrom
auto/nori-slack-command-not-working-20260424-212148

Conversation

@theahura
Copy link
Copy Markdown
Contributor

Summary

🤖 Generated with Nori

  • nori-slack-cli@0.1.0 on npm shipped without dist/, so npm install -g nori-slack-cli created a nori-slack bin pointing at a missing file. Fix: add "files": ["dist"] and "prepare": "npm run build" to package.json; bump to 0.1.1.
  • New test/packaging.test.ts black-box test that npm packs (in an isolated tmpdir to avoid racing with build.test.ts), installs the tarball into another tmpdir, and runs nori-slack list-methods --namespace chat — verifies the install works end-to-end. Runs on every npm test.
  • New .github/workflows/pr-ci.yaml + main-ci.yaml mirroring nori-registrar conventions (kebab-case names, single-entry matrix, .nvmrc-driven Node 22). Steps: install → build → test.
  • Docs updated: README.md now documents npm install -g nori-slack-cli as the primary install path; docs.md/src/docs.md/test/docs.md corrected for pre-existing stale claims (e.g., that postbuild runs npm link, which it never did) and new packaging invariants.

Test Plan

  • CI passes on this PR.
  • After merge + npm publish (manual, from a clean checkout), npm install -g nori-slack-cli@0.1.1 exposes a working nori-slack on PATH.
  • nori-slack list-methods --namespace chat returns JSON with chat.postMessage in the methods array.
  • nori-slack --version prints 0.1.1.

Notes / open questions for review

  • Action versions pinned at @v3 to match nori-registrar — happy to bump to @v4 in a follow-up if preferred.
  • src/index.ts has a hardcoded .version('0.1.1') duplicate with package.json. Left as-is — test/build.test.ts already enforces drift detection by asserting --version matches pkg.version.
  • Did not unpublish 0.1.0 from npm. Within the 72h window it is possible via npm unpublish nori-slack-cli@0.1.0 — your call.

Share Nori with your team: https://www.npmjs.com/package/nori-skillsets

Published nori-slack-cli@0.1.0 shipped without dist/, so `npm install -g`
symlinked bin to a missing file. Add files: ["dist"] and prepare script
so the tarball contains the compiled output, bump to 0.1.1, and add an
end-to-end packaging test that runs on every npm test. Also add pr-ci
and main-ci GitHub workflows pinned to Node 22.

🤖 Generated with [Nori](https://noriagentic.com)

Co-Authored-By: Nori <contact@tilework.tech>
🤖 Generated with [Nori](https://noriagentic.com)

Co-Authored-By: Nori <contact@tilework.tech>
@theahura theahura merged commit 65be6df into main Apr 24, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant