Clarify DateTime32 precision errors#1184
Open
BharatDeva wants to merge 1 commit into
Open
Conversation
|
|
Collaborator
|
Hi, the changes look good. Please assign the CLA. @BharatDeva #1184 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist:
proton: starts/endsfor new code in existing community code base ? Not applicable; this updates Proton-specific DateTime32 handling that is already in the file.Please write user-readable short description of the changes:
This makes the
datetime32(3)error message more direct.Before this change,
datetime32(3)treated3as the firstdatetime32argument and reported it as a timezone type error. That is technically accurate from the parser path, but confusing for users because the input looks like a precision argument.Now, numeric
datetime32(...)arguments fail with a clearer message explaining thatdatetime32does not support precision and thatdatetime64should be used for fractional seconds.A gtest regression was added for
DataTypeFactory::instance().get(datetime32(3))to check the error code and message.Validation performed:
Result:
I could not run the C++ gtest locally on this Windows checkout because there is no configured build directory or C++ toolchain available in the current shell.
Fixes #816