Improve tiger auth status output (#106)

Author: nathanjcochran

.env.sample

@@ -3,8 +3,7 @@
 
 # Tiger Cloud API credentials for integration testing
 TIGER_PUBLIC_KEY_INTEGRATION=your-public-key-here
-TIGER_SECRET_KEY_INTEGRATION=your-secret-key-here  
-TIGER_PROJECT_ID_INTEGRATION=your-project-id-here
+TIGER_SECRET_KEY_INTEGRATION=your-secret-key-here
 
 # Optional: Use existing service for database tests (to avoid creating new services)
 # TIGER_EXISTING_SERVICE_ID_INTEGRATION=existing-service-id-here
@@ -13,4 +12,4 @@ TIGER_PROJECT_ID_INTEGRATION=your-project-id-here
 TIGER_API_URL_INTEGRATION=http://localhost:8080/public/api/v1
 
 # To use these integration variables for regular CLI commands (auth login, etc.):
-# export $(cat .env.prod.test | sed 's/_INTEGRATION//' | xargs)
+# export $(cat .env.prod.test | sed 's/_INTEGRATION//' | xargs)

CLAUDE.md

@@ -100,7 +100,6 @@ go test ./internal/tiger/cmd -run Integration
 # To run integration tests with real API calls, set environment variables:
 export TIGER_PUBLIC_KEY_INTEGRATION=your-public-key
 export TIGER_SECRET_KEY_INTEGRATION=your-secret-key
-export TIGER_PROJECT_ID_INTEGRATION=your-project-id
 export TIGER_API_URL_INTEGRATION=http://localhost:8080/public/api/v1
 
 # Optional: Set this to test database commands with existing service

docs/development.md

@@ -68,7 +68,6 @@ Integration tests execute real API calls against a Tiger environment to validate
    ```bash
    TIGER_PUBLIC_KEY_INTEGRATION=your-public-key-here
    TIGER_SECRET_KEY_INTEGRATION=your-secret-key-here
-   TIGER_PROJECT_ID_INTEGRATION=your-project-id-here
    TIGER_API_URL=http://localhost:8080/public/api/v1  # or production URL
    ```
 

go.mod

@@ -24,6 +24,7 @@ require (
 	go.uber.org/zap v1.27.0
 	golang.org/x/oauth2 v0.31.0
 	golang.org/x/term v0.35.0
+	golang.org/x/text v0.29.0
 	gopkg.in/yaml.v3 v3.0.1
 )
 
@@ -161,7 +162,6 @@ require (
 	golang.org/x/net v0.43.0 // indirect
 	golang.org/x/sync v0.17.0 // indirect
 	golang.org/x/sys v0.36.0 // indirect
-	golang.org/x/text v0.29.0 // indirect
 	golang.org/x/time v0.12.0 // indirect
 	golang.org/x/tools v0.36.0 // indirect
 	golang.org/x/xerrors v0.0.0-20240903120638-7835f813f4da // indirect

internal/tiger/analytics/analytics.go

@@ -137,7 +137,7 @@ func Error(err error) Option {
 // analytics. It automatically includes common properties like ProjectID. The
 // identification is only sent if the client is initialized and analytics are
 // enabled in the config, otherwise it is skipped.
-func (a *Analytics) Identify(event string, options ...Option) {
+func (a *Analytics) Identify(options ...Option) {
 	// Create properties map with user-provided properties
 	properties := map[string]any{}
 	for _, option := range options {

internal/tiger/api/client.go

@@ -3,7 +3,6 @@ package api
 import (
 	"context"
 	"encoding/base64"
-	"errors"
 	"fmt"
 	"net/http"
 	"sync"
@@ -60,51 +59,6 @@ func NewTigerClient(cfg *config.Config, apiKey string) (*ClientWithResponses, er
 	return client, nil
 }
 
-// ValidateAPIKey validates the API key by making a test API call
-func ValidateAPIKey(ctx context.Context, cfg *config.Config, apiKey string, projectID string) error {
-	client, err := NewTigerClient(cfg, apiKey)
-	if err != nil {
-		return fmt.Errorf("failed to create client: %w", err)
-	}
-
-	return ValidateAPIKeyWithClient(ctx, client, projectID)
-}
-
-// ValidateAPIKeyWithClient validates the API key using the provided client interface
-func ValidateAPIKeyWithClient(ctx context.Context, client ClientWithResponsesInterface, projectID string) error {
-	ctx, cancel := context.WithTimeout(ctx, 10*time.Second)
-	defer cancel()
-
-	// Use provided project ID if available, otherwise use a dummy one
-	targetProjectID := projectID
-	if targetProjectID == "" {
-		// Use a dummy project ID for validation when none is provided
-		targetProjectID = "00000000-0000-0000-0000-000000000000"
-	}
-
-	// Try to call a simple endpoint
-	// The API should return 401/403 for invalid API key, and 404 for non-existent project
-	resp, err := client.GetProjectsProjectIdServicesWithResponse(ctx, targetProjectID)
-	if err != nil {
-		return fmt.Errorf("API call failed: %w", err)
-	}
-
-	// Check the response status
-	if resp.StatusCode() != 200 {
-		if resp.StatusCode() == 404 {
-			// Project not found, but API key is valid
-			return nil
-		}
-		if resp.JSON4XX != nil {
-			return resp.JSON4XX
-		} else {
-			return errors.New("unexpected API response: 500")
-		}
-	} else {
-		return nil
-	}
-}
-
 // Error implements the error interface for the Error type.
 // This allows Error values to be used directly as Go errors.
 func (e *Error) Error() string {

internal/tiger/api/client_util.go

@@ -7,122 +7,9 @@ import (
 	"testing"
 
 	"github.com/timescale/tiger-cli/internal/tiger/api"
-	"github.com/timescale/tiger-cli/internal/tiger/api/mocks"
 	"github.com/timescale/tiger-cli/internal/tiger/config"
-	"github.com/timescale/tiger-cli/internal/tiger/util"
-	"go.uber.org/mock/gomock"
 )
 
-func TestValidateAPIKeyWithClient(t *testing.T) {
-	tests := []struct {
-		name          string
-		setupMock     func(*mocks.MockClientWithResponsesInterface)
-		expectedError string
-	}{
-		{
-			name: "valid API key - 200 response",
-			setupMock: func(m *mocks.MockClientWithResponsesInterface) {
-				m.EXPECT().
-					GetProjectsProjectIdServicesWithResponse(gomock.Any(), "00000000-0000-0000-0000-000000000000").
-					Return(&api.GetProjectsProjectIdServicesResponse{
-						HTTPResponse: &http.Response{StatusCode: 200},
-					}, nil)
-			},
-			expectedError: "",
-		},
-		{
-			name: "valid API key - 404 response (project not found)",
-			setupMock: func(m *mocks.MockClientWithResponsesInterface) {
-				m.EXPECT().
-					GetProjectsProjectIdServicesWithResponse(gomock.Any(), "00000000-0000-0000-0000-000000000000").
-					Return(&api.GetProjectsProjectIdServicesResponse{
-						HTTPResponse: &http.Response{StatusCode: 404},
-					}, nil)
-			},
-			expectedError: "",
-		},
-		{
-			name: "invalid API key - 401 response",
-			setupMock: func(m *mocks.MockClientWithResponsesInterface) {
-				m.EXPECT().
-					GetProjectsProjectIdServicesWithResponse(gomock.Any(), "00000000-0000-0000-0000-000000000000").
-					Return(&api.GetProjectsProjectIdServicesResponse{
-						HTTPResponse: &http.Response{StatusCode: 401},
-						JSON4XX:      &api.ClientError{Message: util.Ptr("Invalid or missing authentication credentials")},
-					}, nil)
-			},
-			expectedError: "Invalid or missing authentication credentials",
-		},
-		{
-			name: "invalid API key - 403 response",
-			setupMock: func(m *mocks.MockClientWithResponsesInterface) {
-				m.EXPECT().
-					GetProjectsProjectIdServicesWithResponse(gomock.Any(), "00000000-0000-0000-0000-000000000000").
-					Return(&api.GetProjectsProjectIdServicesResponse{
-						HTTPResponse: &http.Response{StatusCode: 403},
-						JSON4XX:      &api.ClientError{Message: util.Ptr("Invalid or missing authentication credentials")},
-					}, nil)
-			},
-			expectedError: "Invalid or missing authentication credentials",
-		},
-		{
-			name: "unexpected response - 500",
-			setupMock: func(m *mocks.MockClientWithResponsesInterface) {
-				m.EXPECT().
-					GetProjectsProjectIdServicesWithResponse(gomock.Any(), "00000000-0000-0000-0000-000000000000").
-					Return(&api.GetProjectsProjectIdServicesResponse{
-						HTTPResponse: &http.Response{StatusCode: 500},
-					}, nil)
-			},
-			expectedError: "unexpected API response: 500",
-		},
-		{
-			name: "network error",
-			setupMock: func(m *mocks.MockClientWithResponsesInterface) {
-				m.EXPECT().
-					GetProjectsProjectIdServicesWithResponse(gomock.Any(), "00000000-0000-0000-0000-000000000000").
-					Return(nil, context.DeadlineExceeded)
-			},
-			expectedError: "API call failed: context deadline exceeded",
-		},
-	}
-
-	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
-			ctrl := gomock.NewController(t)
-			defer ctrl.Finish()
-
-			mockClient := mocks.NewMockClientWithResponsesInterface(ctrl)
-			tt.setupMock(mockClient)
-
-			err := api.ValidateAPIKeyWithClient(context.Background(), mockClient, "")
-
-			if tt.expectedError == "" {
-				if err != nil {
-					t.Errorf("Expected no error, got: %v", err)
-				}
-			} else {
-				if err == nil {
-					t.Errorf("Expected error containing %q, got nil", tt.expectedError)
-				} else if err.Error() != tt.expectedError {
-					t.Errorf("Expected error %q, got %q", tt.expectedError, err.Error())
-				}
-			}
-		})
-	}
-}
-
-// TestValidateAPIKey_Integration would be an integration test that actually calls the API
-// This should be run with a real API key for integration testing
-func TestValidateAPIKey_Integration(t *testing.T) {
-	if testing.Short() {
-		t.Skip("Skipping integration test in short mode")
-	}
-
-	// This test would require a real API key and network connectivity
-	t.Skip("Integration test requires real API key - implement when needed")
-}
-
 func TestNewTigerClientUserAgent(t *testing.T) {
 	// Create a test server that captures the User-Agent header
 	var capturedUserAgent string