Clean up cmd.SilenceUsage = true settings

Author: nathanjcochran

internal/tiger/cmd/config.go

@@ -90,15 +90,14 @@ func buildConfigSetCmd() *cobra.Command {
 		Args:              cobra.ExactArgs(2),
 		ValidArgsFunction: configOptionCompletion,
 		RunE: func(cmd *cobra.Command, args []string) error {
-			key, value := args[0], args[1]
-
 			cmd.SilenceUsage = true
 
 			cfg, err := config.Load()
 			if err != nil {
 				return fmt.Errorf("failed to load config: %w", err)
 			}
 
+			key, value := args[0], args[1]
 			if err := cfg.Set(key, value); err != nil {
 				return fmt.Errorf("failed to set config: %w", err)
 			}
@@ -118,15 +117,14 @@ func buildConfigUnsetCmd() *cobra.Command {
 		Args:              cobra.ExactArgs(1),
 		ValidArgsFunction: configOptionCompletion,
 		RunE: func(cmd *cobra.Command, args []string) error {
-			key := args[0]
-
 			cmd.SilenceUsage = true
 
 			cfg, err := config.Load()
 			if err != nil {
 				return fmt.Errorf("failed to load config: %w", err)
 			}
 
+			key := args[0]
 			if err := cfg.Unset(key); err != nil {
 				return fmt.Errorf("failed to unset config: %w", err)
 			}

internal/tiger/cmd/db.go

@@ -77,9 +77,11 @@ Examples:
 		RunE: func(cmd *cobra.Command, args []string) error {
 			cfg, err := common.LoadConfig(cmd.Context())
 			if err != nil {
+				cmd.SilenceUsage = true
 				return err
 			}
-			service, err := getServiceDetails(cmd, cfg, args)
+
+			service, err := getServiceDetailsFunc(cmd, cfg, args)
 			if err != nil {
 				return err
 			}
@@ -158,13 +160,16 @@ Examples:
 		Args:              cobra.ArbitraryArgs,
 		ValidArgsFunction: serviceIDCompletion,
 		RunE: func(cmd *cobra.Command, args []string) error {
-			// Separate service ID from additional psql flags
-			serviceArgs, psqlFlags := separateServiceAndPsqlArgs(cmd, args)
 			cfg, err := common.LoadConfig(cmd.Context())
 			if err != nil {
+				cmd.SilenceUsage = true
 				return err
 			}
-			service, err := getServiceDetails(cmd, cfg, serviceArgs)
+
+			// Separate service ID from additional psql flags
+			serviceArgs, psqlFlags := separateServiceAndPsqlArgs(cmd, args)
+
+			service, err := getServiceDetailsFunc(cmd, cfg, serviceArgs)
 			if err != nil {
 				return err
 			}
@@ -238,9 +243,11 @@ Examples:
 		RunE: func(cmd *cobra.Command, args []string) error {
 			cfg, err := common.LoadConfig(cmd.Context())
 			if err != nil {
+				cmd.SilenceUsage = true
 				return err
 			}
-			service, err := getServiceDetails(cmd, cfg, args)
+
+			service, err := getServiceDetailsFunc(cmd, cfg, args)
 			if err != nil {
 				return common.ExitWithCode(common.ExitInvalidParameters, err)
 			}
@@ -316,8 +323,10 @@ Examples:
 		RunE: func(cmd *cobra.Command, args []string) error {
 			cfg, err := common.LoadConfig(cmd.Context())
 			if err != nil {
+				cmd.SilenceUsage = true
 				return err
 			}
+
 			service, err := getServiceDetailsFunc(cmd, cfg, args)
 			if err != nil {
 				return err
@@ -661,23 +670,22 @@ PostgreSQL Configuration Parameters That May Be Set:
 				return fmt.Errorf("--name is required")
 			}
 
-			cmd.SilenceUsage = true
-
 			cfg, err := common.LoadConfig(cmd.Context())
 			if err != nil {
+				cmd.SilenceUsage = true
 				return err
 			}
 
-			// Get password
-			rolePassword, err := getPasswordForRole(passwordFlag)
+			// Get service details
+			service, err := getServiceDetailsFunc(cmd, cfg, args)
 			if err != nil {
-				return fmt.Errorf("failed to determine password: %w", err)
+				return err
 			}
 
-			// Get service details
-			service, err := getServiceDetails(cmd, cfg, args)
+			// Get password
+			rolePassword, err := getPasswordForRole(passwordFlag)
 			if err != nil {
-				return err
+				return fmt.Errorf("failed to determine password: %w", err)
 			}
 
 			// Build connection string
@@ -761,7 +769,6 @@ func buildDbCmd() *cobra.Command {
 
 // getServiceDetails is a helper that handles common service lookup logic and returns the service details
 func getServiceDetails(cmd *cobra.Command, cfg *common.Config, args []string) (api.Service, error) {
-
 	// Determine service ID
 	serviceID, err := getServiceID(cfg.Config, args)
 	if err != nil {

internal/tiger/cmd/service.go

@@ -75,6 +75,7 @@ Examples:
 			// Load config and API client
 			cfg, err := common.LoadConfig(cmd.Context())
 			if err != nil {
+				cmd.SilenceUsage = true
 				return err
 			}
 
@@ -129,14 +130,14 @@ func buildServiceListCmd() *cobra.Command {
 		ValidArgsFunction: cobra.NoFileCompletions,
 		PreRunE:           bindFlags("output"),
 		RunE: func(cmd *cobra.Command, args []string) error {
+			cmd.SilenceUsage = true
+
 			// Load config and API client
 			cfg, err := common.LoadConfig(cmd.Context())
 			if err != nil {
 				return err
 			}
 
-			cmd.SilenceUsage = true
-
 			// Make API call to list services
 			ctx, cancel := context.WithTimeout(cmd.Context(), 30*time.Second)
 			defer cancel()
@@ -442,6 +443,7 @@ Examples:
 			// Load config and API client
 			cfg, err := common.LoadConfig(cmd.Context())
 			if err != nil {
+				cmd.SilenceUsage = true
 				return err
 			}
 
@@ -453,7 +455,6 @@ Examples:
 
 			// Get password from flag or environment variable via viper
 			password := viper.GetString("new_password")
-
 			if autoGenerate && password != "" {
 				return fmt.Errorf("cannot use --auto-generate and --new-password together")
 			}
@@ -926,6 +927,7 @@ Examples:
 			// Load config and API client
 			cfg, err := common.LoadConfig(cmd.Context())
 			if err != nil {
+				cmd.SilenceUsage = true
 				return err
 			}
 
@@ -1021,6 +1023,7 @@ Examples:
 			// Load config and API client
 			cfg, err := common.LoadConfig(cmd.Context())
 			if err != nil {
+				cmd.SilenceUsage = true
 				return err
 			}
 
@@ -1178,6 +1181,7 @@ Examples:
 			// Load config and API client
 			cfg, err := common.LoadConfig(cmd.Context())
 			if err != nil {
+				cmd.SilenceUsage = true
 				return err
 			}
 

internal/tiger/cmd/version.go

@@ -34,6 +34,8 @@ func buildVersionCmd() *cobra.Command {
 		Args:              cobra.NoArgs,
 		ValidArgsFunction: cobra.NoFileCompletions,
 		RunE: func(cmd *cobra.Command, args []string) error {
+			cmd.SilenceUsage = true
+
 			versionOutput := VersionOutput{
 				Version:   config.Version,
 				BuildTime: config.BuildTime,
@@ -76,7 +78,6 @@ func buildVersionCmd() *cobra.Command {
 			}
 			if updateAvailable {
 				cmd.SilenceErrors = true
-				cmd.SilenceUsage = true
 				return common.ExitWithCode(common.ExitUpdateAvailable, nil)
 			}
 			return nil