File tree Expand file tree Collapse file tree
Expand file tree Collapse file tree Original file line number Diff line number Diff line change @@ -208,12 +208,21 @@ Review
208208 push changes to the contributor branch, or merge the PR and then
209209 open a new PR against upstream.
210210
211- * If you push to a contributor branch leave a comment explaining what
211+ * If you push to a contributor branch, leave a comment explaining what
212212 you did, ex "I took the liberty of pushing a small clean-up PR to
213213 your branch, thanks for your work.". If you are going to make
214214 substantial changes to the code or intent of the PR please check
215215 with the contributor first.
216216
217+ * If you find yourself spending too much time on a PR, or feeling frustrated,
218+ it's ok to step back. You can ask for help from other reviewers, or if you are
219+ the only reviewer, you can ask the contributor to find another reviewer or to
220+ wait until you have more time. Make sure to communicate with the contributor
221+ to set the right expectations, e.g. "I currently don't have the bandwidth to
222+ review this PR, but will try to loop someone else in." If you feel like this
223+ PR is not a good fit for the project, you can close it with an explanation or
224+ add the "status: autoclose candidate" label to trigger the autoclose workflow.
225+
217226.. _pr-approval :
218227
219228Approval
You can’t perform that action at this time.
0 commit comments