Skip to content

Commit 9b41179

Browse files
authored
Merge pull request matplotlib#31598 from melissawm/reviewer-guide
DOC, DX: Add note about stepping back from PR reviews
2 parents 42dee4e + 2c41a2d commit 9b41179

1 file changed

Lines changed: 10 additions & 1 deletion

File tree

doc/devel/pr_guide.rst

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -208,12 +208,21 @@ Review
208208
push changes to the contributor branch, or merge the PR and then
209209
open a new PR against upstream.
210210

211-
* If you push to a contributor branch leave a comment explaining what
211+
* If you push to a contributor branch, leave a comment explaining what
212212
you did, ex "I took the liberty of pushing a small clean-up PR to
213213
your branch, thanks for your work.". If you are going to make
214214
substantial changes to the code or intent of the PR please check
215215
with the contributor first.
216216

217+
* If you find yourself spending too much time on a PR, or feeling frustrated,
218+
it's ok to step back. You can ask for help from other reviewers, or if you are
219+
the only reviewer, you can ask the contributor to find another reviewer or to
220+
wait until you have more time. Make sure to communicate with the contributor
221+
to set the right expectations, e.g. "I currently don't have the bandwidth to
222+
review this PR, but will try to loop someone else in." If you feel like this
223+
PR is not a good fit for the project, you can close it with an explanation or
224+
add the "status: autoclose candidate" label to trigger the autoclose workflow.
225+
217226
.. _pr-approval:
218227

219228
Approval

0 commit comments

Comments
 (0)