Skip to content

Commit 49a6bc8

Browse files
authored
Merge pull request #136 from timlnx/best-practices
best-practices: pylint 10.00/10, real docstrings, swap flake8 for pylint in CI
2 parents b5531bb + 00db67f commit 49a6bc8

36 files changed

Lines changed: 696 additions & 432 deletions

.github/workflows/python.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,11 @@ jobs:
3636
- name: Pre-Tests code smell validation
3737
run: |
3838
pycodestyle -v --ignore=E501 bitmath/__init__.py tests/
39-
flake8 --select=F bitmath/__init__.py tests/
39+
40+
- name: Lint with pylint
41+
if: matrix.os == 'ubuntu-latest' && matrix.python-version == '3.12'
42+
run: |
43+
pylint bitmath/__init__.py
4044
4145
- name: Run Unit Tests
4246
run: |

LICENSES/MIT.txt

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
The MIT License (MIT)
2+
3+
Copyright © 2014-2026 Tim Case (fmr. tbielawa) <bitmath@lnx.cx>
4+
5+
Permission is hereby granted, free of charge, to any person obtaining a copy of
6+
this software and associated documentation files (the "Software"), to deal in
7+
the Software without restriction, including without limitation the rights to
8+
use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of
9+
the Software, and to permit persons to whom the Software is furnished to do so,
10+
subject to the following conditions:
11+
12+
The above copyright notice and this permission notice shall be included in all
13+
copies or substantial portions of the Software.
14+
15+
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
16+
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
17+
FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
18+
COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER
19+
IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
20+
CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

Makefile

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -209,12 +209,12 @@ ci-pycodestyle:
209209
@echo "#############################################"
210210
. $(NAME)env3/bin/activate && pycodestyle -v --ignore=E501 bitmath/__init__.py tests/*.py
211211

212-
ci-flake8:
212+
ci-pylint:
213213
@echo ""
214214
@echo "#################################################"
215-
@echo "# Running Flake8 Compliance Tests in virtualenv"
215+
@echo "# Running pylint in virtualenv"
216216
@echo "#################################################"
217-
. $(NAME)env3/bin/activate && flake8 --select=F bitmath/__init__.py tests/*.py
217+
. $(NAME)env3/bin/activate && pylint bitmath/__init__.py
218218

219-
ci: clean uniquetestnames virtualenv ci-list-deps ci-pycodestyle ci-flake8 ci-unittests
219+
ci: clean uniquetestnames virtualenv ci-list-deps ci-pycodestyle ci-pylint ci-unittests
220220
:

bitmath.1

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,12 @@
22
.\" Title: bitmath
33
.\" Author: [see the "AUTHOR" section]
44
.\" Generator: DocBook XSL Stylesheets vsnapshot <http://docbook.sf.net/>
5-
.\" Date: 04/17/2026
5+
.\" Date: 05/04/2026
66
.\" Manual: python-bitmath
7-
.\" Source: bitmath 2.0.0
7+
.\" Source: bitmath 2.0.1
88
.\" Language: English
99
.\"
10-
.TH "BITMATH" "1" "04/17/2026" "bitmath 2\&.0\&.0" "python\-bitmath"
10+
.TH "BITMATH" "1" "05/04/2026" "bitmath 2\&.0\&.1" "python\-bitmath"
1111
.\" -----------------------------------------------------------------
1212
.\" * Define some portability stuff
1313
.\" -----------------------------------------------------------------

0 commit comments

Comments
 (0)