Py39 wrapup#121
Merged
Merged
Conversation
…stdlib Fix pyflakes F821 issues in bitmath/__init__.py - Drop explicit (object) base from class Bitmath (modern Python syntax) - Remove unnecessary global _FORMAT_REPR declaration (F823 unused global) - Fix redundant single-type isinstance tuples: isinstance(s, (str)) → isinstance(s, str) These changes modernize the code for Python 3 while maintaining all functionality. All 292 tests pass with 100% coverage. Convert % format strings to f-strings; update stale Py2 docs URL Replace list([...]).index(True) with next(enumerate()) in parse_string Fix fcntl.ioctl buffer: pass int size instead of str (Python 3 correctness) Remove os_name() wrapper — use os.name directly, patch via bitmath.os.name in tests
Test Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description: wraps up just about all of of the python modernization work
Final passes at fully modernizing the code base to be python 3.9+ only. No functional changes. Just "Doing it the modern-ish python way" now.