chore: update Angular and related dependencies to version 21.x

- Upgraded Angular packages to version 21.0.x for improved performance and features.
- Updated other dependencies including @auth0/auth0-spa-js and @microsoft/signalr.
- Adjusted devDependencies for Angular ESLint and TypeScript to align with the new Angular version.
- Updated prettier and jasmine-core to their latest versions.

feat: add composite index migration for Log table

- Created a new SQL migration script to add a composite index on (Deployment, Pod, TimeStamp) for better query performance on /api/log/counts and /api/log/times endpoints.
- Added README documentation for the migration process, expected time, and rollback instructions.

Author: Timothy Dodd

database-migrations/001-add-composite-indexes.sql

@@ -0,0 +1,43 @@
+-- Migration: Add composite index for better query performance
+-- Run this during a maintenance window as it may take time on large tables
+--
+-- This index significantly improves performance for:
+-- - /api/log/counts endpoint (GetDeploymentCounts)
+-- - /api/log/times endpoint (GetLatestEntryTimes)
+--
+-- Estimated time: Depends on table size
+--   - 1M rows: ~30 seconds
+--   - 10M rows: ~5 minutes
+--   - 100M rows: ~30-60 minutes
+--
+-- Progress monitoring:
+--   You can check progress in another session with:
+--   SHOW PROCESSLIST;
+
+-- Check if index already exists before creating
+SELECT
+    CASE
+        WHEN COUNT(*) > 0 THEN 'Index already exists, skipping creation'
+        ELSE 'Index does not exist, creating...'
+    END AS status
+FROM information_schema.statistics
+WHERE table_schema = DATABASE()
+AND table_name = 'Log'
+AND index_name = 'Deployment_Pod_TimeStamp_idx';
+
+-- Create the composite index
+-- Note: Remove the comment below to execute
+-- CREATE INDEX Deployment_Pod_TimeStamp_idx ON `Log` (Deployment, Pod, TimeStamp);
+
+-- Verify index was created
+SELECT
+    index_name,
+    column_name,
+    seq_in_index,
+    cardinality,
+    index_type
+FROM information_schema.statistics
+WHERE table_schema = DATABASE()
+AND table_name = 'Log'
+AND index_name = 'Deployment_Pod_TimeStamp_idx'
+ORDER BY seq_in_index;

database-migrations/README.md

@@ -0,0 +1,76 @@
+# Database Migrations
+
+This directory contains SQL migration scripts for the LogMk database.
+
+## Migration 001: Add Composite Indexes
+
+**File:** `001-add-composite-indexes.sql`
+
+### Problem
+The `/api/log/counts` and `/api/log/times` endpoints perform `GROUP BY Deployment, Pod` queries on the entire Log table. Without proper indexing, these queries can timeout on large datasets (>1M rows).
+
+### Solution
+Create a composite index on `(Deployment, Pod, TimeStamp)` columns.
+
+### When to Run
+- If you see timeout errors in the LogMkAgent logs when calling `/api/log/counts` or `/api/log/times`
+- If the API logs show: `PERFORMANCE WARNING: Missing composite index 'Deployment_Pod_TimeStamp_idx'`
+- During a scheduled maintenance window (recommended for production)
+
+### How to Run
+
+1. **Connect to your MySQL database:**
+   ```bash
+   mysql -h <host> -u <user> -p <database>
+   ```
+
+2. **Check if index exists:**
+   ```sql
+   SELECT COUNT(*)
+   FROM information_schema.statistics
+   WHERE table_schema = DATABASE()
+   AND table_name = 'Log'
+   AND index_name = 'Deployment_Pod_TimeStamp_idx';
+   ```
+   If the count is 0, the index doesn't exist and should be created.
+
+3. **Create the index:**
+   ```sql
+   CREATE INDEX Deployment_Pod_TimeStamp_idx ON `Log` (Deployment, Pod, TimeStamp);
+   ```
+
+4. **Monitor progress (in another MySQL session):**
+   ```sql
+   SHOW PROCESSLIST;
+   ```
+
+### Expected Time
+- **1M rows:** ~30 seconds
+- **10M rows:** ~5 minutes
+- **100M rows:** ~30-60 minutes
+
+### Impact
+- **During creation:** High CPU and I/O usage, queries to the Log table may be slower
+- **After creation:** 10-100x faster queries for counts and times endpoints
+- **Disk space:** Approximately 10-20% of the Log table size
+
+### Rollback
+If you need to remove the index:
+```sql
+DROP INDEX Deployment_Pod_TimeStamp_idx ON `Log`;
+```
+
+### Alternative: Online Index Creation (MySQL 5.6+)
+For minimal downtime on large tables:
+```sql
+CREATE INDEX Deployment_Pod_TimeStamp_idx ON `Log` (Deployment, Pod, TimeStamp) ALGORITHM=INPLACE, LOCK=NONE;
+```
+
+This allows concurrent reads/writes during index creation but may take longer.
+
+## Future Migrations
+
+Add new migration files with incremental numbering:
+- `002-description.sql`
+- `003-description.sql`
+- etc.

src/LogMkAgent/LogMkAgent.csproj

@@ -13,10 +13,10 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.Extensions.Caching.Memory" Version="9.0.11" />
-    <PackageReference Include="Microsoft.Extensions.Http" Version="9.0.11" />
-    <PackageReference Include="Microsoft.Extensions.Hosting" Version="9.0.11" />
-    <PackageReference Include="System.Text.Json" Version="9.0.11" />
+    <PackageReference Include="Microsoft.Extensions.Caching.Memory" Version="10.0.0" />
+    <PackageReference Include="Microsoft.Extensions.Http" Version="10.0.0" />
+    <PackageReference Include="Microsoft.Extensions.Hosting" Version="10.0.0" />
+    <PackageReference Include="System.Text.Json" Version="10.0.0" />
   </ItemGroup>
 
   <ItemGroup>

src/LogMkApi/Controllers/LogController.cs

@@ -228,10 +228,17 @@ public async Task<ActionResult<LogResponse>> Create(
                 .ToDictionary(g => g.Key, g => g.Count());
 
             _logger.LogWarning("Batch {BatchId}: {ErrorCount} validation errors, {SkippedCount} logs skipped. " +
-                "Error breakdown: {ErrorSummary}", 
-                batchId, errors.Count, skippedCount, 
+                "Error breakdown: {ErrorSummary}",
+                batchId, errors.Count, skippedCount,
                 string.Join(", ", errorSummary.Select(kvp => $"{kvp.Key}: {kvp.Value}")));
-            
+
+            // Log individual rejected lines for debugging (limit to first 5)
+            foreach (var error in errors.Take(5))
+            {
+                _logger.LogDebug("Batch {BatchId}: Rejected log at index {Index}. Errors: [{Errors}]. Details: {LogLine}",
+                    batchId, error.Index, string.Join(", ", error.Errors), error.LogLine);
+            }
+
             _metrics.IncrementErrors("validation", skippedCount);
         }
 

src/LogMkApi/Data/DatabaseInitializer.cs

@@ -61,20 +61,23 @@ FROM information_schema.statistics
 
             if (!indexExists)
             {
-                _logger.LogInformation("Creating missing composite index Deployment_Pod_TimeStamp_idx on Log table");
+                _logger.LogWarning(
+                    "PERFORMANCE WARNING: Missing composite index 'Deployment_Pod_TimeStamp_idx' on Log table. " +
+                    "This will cause slow queries for /api/log/counts and /api/log/times endpoints. " +
+                    "To create the index manually, run: CREATE INDEX Deployment_Pod_TimeStamp_idx ON `Log` (Deployment, Pod, TimeStamp);");
 
-                // Create the index
-                var createIndexSql = @"
-                    CREATE INDEX Deployment_Pod_TimeStamp_idx
-                    ON `Log` (Deployment, Pod, TimeStamp)";
-
-                db.Execute(createIndexSql);
-                _logger.LogInformation("Successfully created composite index Deployment_Pod_TimeStamp_idx");
+                // Note: We don't create the index automatically because it can take a very long time
+                // on large tables and cause startup timeout. It should be created manually during
+                // a maintenance window with: CREATE INDEX Deployment_Pod_TimeStamp_idx ON `Log` (Deployment, Pod, TimeStamp);
+            }
+            else
+            {
+                _logger.LogInformation("Composite index Deployment_Pod_TimeStamp_idx exists on Log table");
             }
         }
         catch (Exception ex)
         {
-            _logger.LogWarning(ex, "Failed to create missing indexes, they may already exist or require manual creation");
+            _logger.LogWarning(ex, "Failed to check indexes");
         }
     }
 }

src/LogMkApi/Data/LogRepo.cs

@@ -161,11 +161,11 @@ public async Task<IEnumerable<LatestDeploymentEntry>> GetLatestEntryTimes()
     {
         using (var db = _dbFactory.CreateConnection())
         {
-            // Use the composite index (Deployment, Pod, TimeStamp) for optimal performance
-            // The index is created by DatabaseInitializer.EnsureLogIndexes()
+            // This query will be slow on large tables without the composite index (Deployment, Pod, TimeStamp)
+            // See DatabaseInitializer.EnsureLogIndexes() for instructions on creating the index
             var query = @"
     SELECT Deployment, Pod, MAX(TimeStamp) AS TimeStamp
-    FROM Log USE INDEX (Deployment_Pod_TimeStamp_idx)
+    FROM Log
     GROUP BY Deployment, Pod
 ";
             return await db.QueryAsync<LatestDeploymentEntry>(query);
@@ -176,11 +176,11 @@ public async Task<IEnumerable<DeploymentCount>> GetDeploymentCounts()
     {
         using (var db = _dbFactory.CreateConnection())
         {
-            // Use the composite index (Deployment, Pod, TimeStamp) for optimal performance
-            // The index is created by DatabaseInitializer.EnsureLogIndexes()
+            // This query will be slow on large tables without the composite index (Deployment, Pod, TimeStamp)
+            // See DatabaseInitializer.EnsureLogIndexes() for instructions on creating the index
             var query = @"
     SELECT Deployment, Pod, COUNT(*) AS Count
-    FROM Log USE INDEX (Deployment_Pod_TimeStamp_idx)
+    FROM Log
     GROUP BY Deployment, Pod
 ";
             return await db.QueryAsync<DeploymentCount>(query);

src/LogMkApi/LogMkApi.csproj

@@ -15,11 +15,11 @@
   <ItemGroup>
 
     <PackageReference Include="Microsoft.AspNetCore.Authentication.JwtBearer" Version="9.0.11" />
-    <PackageReference Include="Microsoft.Extensions.Diagnostics.HealthChecks" Version="9.0.11" />
+    <PackageReference Include="Microsoft.Extensions.Diagnostics.HealthChecks" Version="10.0.0" />
     <PackageReference Include="MySql.Data" Version="9.5.0" />
-    <PackageReference Include="System.Text.Json" Version="9.0.11" />
+    <PackageReference Include="System.Text.Json" Version="10.0.0" />
     <PackageReference Include="Microsoft.AspNetCore.SpaProxy">
-      <Version>9.0.11</Version>
+      <Version>10.0.0</Version>
     </PackageReference>
   </ItemGroup>
   <ItemGroup>

src/LogMkCommon/LogParser.cs

@@ -47,6 +47,7 @@ public static class LogParser
             @"(\d{4}-\d{2}-\d{2}\s+\d{2}:\d{2}:\d{2})" // 2024-01-15 12:34:56
         };
 
+        // First try standard patterns
         foreach (var pattern in patterns)
         {
             var match = Regex.Match(line, pattern);
@@ -59,6 +60,22 @@ public static class LogParser
             }
         }
 
+        // Try to handle malformed time-only formats like "21: 28: 16]" (spaces around colons)
+        var malformedTimePattern = @"(\d{1,2}):\s*(\d{1,2}):\s*(\d{1,2})\]";
+        var malformedMatch = Regex.Match(line, malformedTimePattern);
+        if (malformedMatch.Success)
+        {
+            if (int.TryParse(malformedMatch.Groups[1].Value, out var hours) &&
+                int.TryParse(malformedMatch.Groups[2].Value, out var minutes) &&
+                int.TryParse(malformedMatch.Groups[3].Value, out var seconds) &&
+                hours >= 0 && hours <= 23 && minutes >= 0 && minutes <= 59 && seconds >= 0 && seconds <= 59)
+            {
+                // Use today's date with the parsed time
+                var today = DateTimeOffset.UtcNow.Date;
+                return new DateTimeOffset(today.Year, today.Month, today.Day, hours, minutes, seconds, TimeSpan.Zero);
+            }
+        }
+
         return null;
     }