Skip to content

Commit e5756a1

Browse files
author
Timothy Dodd
committed
refactor: replace dropdown components with select components across log filter and settings pages
1 parent 3c8e32b commit e5756a1

5 files changed

Lines changed: 12 additions & 12 deletions

File tree

src/LogMkWeb/src/app/_pages/main-log-page/log-filter-controls/log-filter-controls.component.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import { startOfToday, subDays, subHours, subMonths } from 'date-fns'; // Import
66
import { LucideAngularModule } from 'lucide-angular';
77

88
import { debounceTime } from 'rxjs';
9-
import { DropdownComponent, ModalContainerService, ToastService } from '@rd-ui';
9+
import { SelectComponent, ModalContainerService, ToastService } from '@rd-ui';
1010
import { FilterPresetsModalComponent } from '../../../_components/filter-presets-modal/filter-presets-modal.component';
1111
import { TimeFilter, TimeFilterDropdownComponent } from '../../../_components/time-filter-dropdown/time-filter-dropdown.component';
1212
import { AudioService } from '../../../_services/audio.service';
@@ -27,7 +27,7 @@ import { LogFilterState } from '../_services/log-filter-state';
2727
@Component({
2828
selector: 'app-log-filter-controls',
2929
standalone: true,
30-
imports: [FormsModule, DropdownComponent, TimeFilterDropdownComponent, LucideAngularModule],
30+
imports: [FormsModule, SelectComponent, TimeFilterDropdownComponent, LucideAngularModule],
3131
template: `
3232
<div class="compact-toolbar filter-container-base">
3333
<!-- Search Input -->
@@ -45,7 +45,7 @@ import { LogFilterState } from '../_services/log-filter-state';
4545
4646
<!-- Log Levels Filter -->
4747
<div class="filter-item">
48-
<rd-dropdown
48+
<rd-select
4949
id="log-level-select"
5050
[items]="logLevels"
5151
[triState]="true"
@@ -56,12 +56,12 @@ import { LogFilterState } from '../_services/log-filter-state';
5656
size="compact"
5757
[ngModel]="logFilterState.triStateLogLevel()"
5858
(ngModelChange)="logFilterState.triStateLogLevel.set($event)"
59-
></rd-dropdown>
59+
></rd-select>
6060
</div>
6161
6262
<!-- Pods Filter -->
6363
<div class="filter-item">
64-
<rd-dropdown
64+
<rd-select
6565
id="pod-select"
6666
[items]="pods()"
6767
[triState]="true"
@@ -72,7 +72,7 @@ import { LogFilterState } from '../_services/log-filter-state';
7272
size="compact"
7373
[ngModel]="logFilterState.triStatePod()"
7474
(ngModelChange)="logFilterState.triStatePod.set($event)"
75-
></rd-dropdown>
75+
></rd-select>
7676
</div>
7777
7878
<!-- Time Range Filter -->

src/LogMkWeb/src/app/_pages/settings-page/settings-page.component.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,12 +69,12 @@ <h5>Recent Activity</h5>
6969
<div class="purge-action-row">
7070
<div class="form-group time-range-group">
7171
<label>Time Range</label>
72-
<rd-dropdown
72+
<rd-select
7373
[options]="timeRangeOptions"
7474
[placeholder]="'Select time range'"
7575
[formControl]="timeRangeControl"
7676
(selectionChange)="onTimeRangeSelect($event)"
77-
></rd-dropdown>
77+
></rd-select>
7878
</div>
7979

8080
<button

src/LogMkWeb/src/app/_pages/settings-page/settings-page.component.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { Component, inject, OnInit, signal } from '@angular/core';
22
import { FormControl, FormsModule, ReactiveFormsModule } from '@angular/forms';
33
import { Router } from '@angular/router';
4-
import { ConfirmDialogService, DropdownComponent, ToastService } from '@rd-ui';
4+
import { ConfirmDialogService, SelectComponent, ToastService } from '@rd-ui';
55
import { firstValueFrom } from 'rxjs';
66
import { WorkQueueComponent } from '../../_components/work-queue/work-queue.component';
77
import { LogApiService } from '../../_services/log.api';
@@ -22,7 +22,7 @@ interface TimeRange {
2222
@Component({
2323
selector: 'app-settings-page',
2424
standalone: true,
25-
imports: [FormsModule, ReactiveFormsModule, DropdownComponent, WorkQueueComponent],
25+
imports: [FormsModule, ReactiveFormsModule, SelectComponent, WorkQueueComponent],
2626
templateUrl: './settings-page.component.html',
2727
styleUrl: './settings-page.component.scss',
2828
})

src/LogMkWeb/src/variables.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
--rd-border-color: var(--border-color);
2222
--rd-focus-ring: var(--focus-ring);
2323
--rd-modal-bg: var(--modal-bg);
24-
--rd-dropdown-bg: var(--dropdown-bg);
24+
--rd-select-bg: var(--dropdown-bg);
2525
--rd-shadow-color: rgba(0, 0, 0, 0.3);
2626
--rd-border-radius: 8px;
2727
--rd-border-radius-sm: 4px;

0 commit comments

Comments
 (0)