Refactor email storage logic and update default behavior

Updated `EmailSettings` to set `StoreMovedMessages` default to `false`, changing the default behavior for storing moved messages.

Refactored `ProcessSingleMoveOperationAsync` to remove the `dbConnection` parameter and conditionally save emails to the database based on the `StoreMovedMessages` configuration.

Encapsulated database connection logic within `SaveEmailsToDatabase`, removing the need to pass external connections and ensuring proper disposal of connections.

These changes simplify database handling, improve modularity, and introduce a feature toggle for storing moved messages.

Author: Timothy Dodd

src/MailZort/Program.cs

@@ -90,7 +90,7 @@ public class EmailSettings
     public string? Password { get; set; }
     public int Port { get; set; }
     public bool UseSsl { get; set; }
-    public bool StoreMovedMessages { get; set; } = true;
+    public bool StoreMovedMessages { get; set; } = false;
     public int BatchProcessingIntervalSeconds { get; set; } = 60; // Default to 60 seconds
 }
 public class RuleTrigger

src/MailZort/Services/EmailMonitoringService.cs

@@ -366,13 +366,11 @@ private async Task ProcessQueuedMoveOperationsAsync()
             var processedCount = 0;
             var stopwatch = System.Diagnostics.Stopwatch.StartNew();
 
-            using var dbConnection = _mailDb.GetConnection();
-
             while (_moveQueue.TryDequeue(out var moveOperation) && moveOperation != null)
             {
                 try
                 {
-                    await ProcessSingleMoveOperationAsync(dbConnection, moveOperation);
+                    await ProcessSingleMoveOperationAsync(moveOperation);
                     processedCount++;
                 }
                 catch (Exception ex)
@@ -394,7 +392,7 @@ private async Task ProcessQueuedMoveOperationsAsync()
             }
         }
 
-        private async Task ProcessSingleMoveOperationAsync(IDbConnection dbConnection, EmailMoveOperation moveOperation)
+        private async Task ProcessSingleMoveOperationAsync(EmailMoveOperation moveOperation)
         {
             if (!moveOperation.Emails.Any())
                 return;
@@ -409,12 +407,13 @@ private async Task ProcessSingleMoveOperationAsync(IDbConnection dbConnection, E
                 var destinationFolder = GetDestinationFolder(moveOperation.DestinationFolder);
 
                 // Perform the move
-
                 await sourceFolder.MoveToAsync(moveOperation.EmailIds, destinationFolder);
 
-                // Save to database
-                SaveEmailsToDatabase(dbConnection, moveOperation.Emails);
-
+                // Save to database if enabled
+                if (_config.StoreMovedMessages)
+                {
+                    SaveEmailsToDatabase(moveOperation.Emails);
+                }
 
                 _logger.LogInformation("📁 Moved {Count} emails from {Source} to {Destination}",
                     moveOperation.Emails.Count, moveOperation.SourceFolder, moveOperation.DestinationFolder);
@@ -439,8 +438,9 @@ private IMailFolder GetDestinationFolder(string folderName)
             return _client!.GetFolder(folderName);
         }
 
-        private void SaveEmailsToDatabase(IDbConnection dbConnection, List<Email> emails)
+        private void SaveEmailsToDatabase(List<Email> emails)
         {
+            using var dbConnection = _mailDb.GetConnection();
             foreach (var email in emails)
             {
                 try