Refactor: Remove SQLite database dependency

This commit removes the `MailDb` class and all associated database operations, eliminating the dependency on ServiceStack.OrmLite and SQLite. The `SettingsHelper` class was also removed, and configuration management was streamlined to directly use the application's base directory.

Key changes:
- Removed `MailDb` and `SettingsHelper` classes.
- Eliminated `ServiceStack.OrmLite.Sqlite.Data` package reference.
- Simplified `Program.cs` by restructuring configuration setup and adding `PrintRules` for improved rule logging.
- Updated `Rule` and `EmailSettings` classes to remove database-related properties.
- Refactored `BatchRuleProcessor` and `RuleMatcher` to simplify rule value handling.
- Removed database operations from `EmailMonitoringService`.
- Updated `appsettings.json` to remove `StoreMovedMessages` setting.

These changes simplify the application's architecture by removing the database layer, focusing on in-memory processing of email rules, and improving maintainability.

Author: Timothy Dodd

src/MailZort/MailDb.cs

@@ -34,7 +34,6 @@
 	  <DotNetCliToolReference Include="Microsoft.Extensions.SecretManager.Tools" Version="2.0.0" />
 	  <PackageReference Include="Microsoft.Extensions.Logging" Version="10.0.3" />
 	  <PackageReference Include="Microsoft.NET.Build.Containers" Version="10.0.103" />
-	  <PackageReference Include="ServiceStack.OrmLite.Sqlite.Data" Version="10.0.6" />
 	  <PackageReference Include="System.Text.Json" Version="10.0.3" />
 	  <PackageReference Include="System.Text.RegularExpressions" Version="4.3.1" />
   </ItemGroup>

src/MailZort/MailZort.csproj

@@ -1,46 +1,31 @@
-// See https://aka.ms/new-console-template for more information
-
-
 using MailKit;
-using MailZort;
 using MailZort.Services;
-using ServiceStack;
 
 internal class Program
 {
     static async Task Main(string[] args)
     {
-        SettingsHelper settingHelper = new();
-        IConfigurationBuilder builder = new ConfigurationBuilder()
-             .SetBasePath(settingHelper.SettingPath)
-          .AddJsonFile("appsettings.json", optional: true, reloadOnChange: true)
-          .AddEnvironmentVariables();
-
-        builder = builder.AddUserSecrets<Program>();
-
-        IConfiguration configuration = builder.Build();
-
         var host = Host.CreateDefaultBuilder(args)
             .ConfigureAppConfiguration((context, config) =>
             {
-                // Use the configuration we already built
-                config.AddConfiguration(configuration);
+                config.Sources.Clear();
+                config.SetBasePath(AppDomain.CurrentDomain.BaseDirectory);
+                config.AddJsonFile("appsettings.json", optional: false);
+                config.AddEnvironmentVariables();
+                config.AddUserSecrets<Program>();
             })
             .ConfigureServices((context, services) =>
             {
-                var rules = context.Configuration.GetSection("Rules")?.Get<IEnumerable<Rule>>()?.Where(x => x.IsEnabled).ToList();
+                var rules = context.Configuration.GetSection("Rules").Get<List<Rule>>()
+                    ?.Where(x => x.IsEnabled).ToList();
+
+                PrintRules(rules);
 
-                // Freeze rule values into arrays to prevent concurrent enumeration issues during parallel processing
                 if (rules != null && rules.Any())
                 {
-                    foreach (var rule in rules)
-                    {
-                        if (rule.Values != null)
-                            rule.FrozenValues = rule.Values.ToArray();
-                    }
                     services.AddSingleton(rules);
                 }
-                // Bind email configuration from appsettings.json
+
                 var emailConfig = new EmailSettings();
                 context.Configuration.GetSection("EmailSettings").Bind(emailConfig);
 
@@ -52,13 +37,9 @@ static async Task Main(string[] args)
                 }
 
                 services.AddSingleton(emailConfig);
-                services.AddSingleton<MailDb>();
                 services.AddSingleton<IBatchRuleProcessor, BatchRuleProcessor>();
                 services.AddSingleton<IEmailMover, EmailMover>();
-
                 services.AddSingleton<RuleMatcher>();
-                services.AddSingleton(x => settingHelper);
-                // Register the background service
                 services.AddHostedService<EmailMonitoringService>();
             })
             .ConfigureLogging(logging =>
@@ -74,6 +55,45 @@ static async Task Main(string[] args)
 
         await host.RunAsync();
     }
+
+    private static void PrintRules(List<Rule>? rules)
+    {
+        Console.WriteLine();
+        Console.WriteLine("=== Rules Configuration ===");
+
+        if (rules == null || !rules.Any())
+        {
+            Console.WriteLine("  WARNING: No rules loaded!");
+            Console.WriteLine("===========================");
+            Console.WriteLine();
+            return;
+        }
+
+        Console.WriteLine($"  Total rules: {rules.Count}");
+        Console.WriteLine();
+
+        for (int i = 0; i < rules.Count; i++)
+        {
+            var rule = rules[i];
+            var action = rule.Action == RuleAction.MarkImportant ? "Flag" : $"Move -> {rule.MoveTo}";
+            var values = rule.Values != null ? string.Join(", ", rule.Values) : "none";
+            var filters = new List<string>();
+            if (rule.DaysOld > 0) filters.Add($"DaysOld>={rule.DaysOld}");
+            if (rule.RequireUnread == true) filters.Add("UnreadOnly");
+            if (rule.RequireNotImportant == true) filters.Add("NotImportant");
+
+            Console.WriteLine($"  [{i + 1}] {rule.Name}");
+            Console.WriteLine($"      {rule.Folder} -> {action}");
+            Console.WriteLine($"      Match: {rule.ExpressionType} in {rule.LookIn}");
+            Console.WriteLine($"      Values: [{values}]");
+            if (filters.Any())
+                Console.WriteLine($"      Filters: {string.Join(", ", filters)}");
+            Console.WriteLine();
+        }
+
+        Console.WriteLine("===========================");
+        Console.WriteLine();
+    }
 }
 
 public class Rule
@@ -88,11 +108,6 @@ public class Rule
     public int DaysOld { get; set; }
     public List<string>? Values { get; set; }
     /// <summary>
-    /// Thread-safe frozen copy of Values, set at startup for use during parallel processing.
-    /// </summary>
-    [System.Text.Json.Serialization.JsonIgnore]
-    public string[]? FrozenValues { get; set; }
-    /// <summary>
     /// If true, rule only matches unread emails. If false or null, read status is ignored.
     /// </summary>
     public bool? RequireUnread { get; set; }
@@ -110,8 +125,7 @@ public class EmailSettings
     public string? Password { get; set; }
     public int Port { get; set; }
     public bool UseSsl { get; set; }
-    public bool StoreMovedMessages { get; set; } = false;
-    public int BatchProcessingIntervalSeconds { get; set; } = 60; // Default to 60 seconds
+    public int BatchProcessingIntervalSeconds { get; set; } = 60;
     public bool InboxCleanupEnabled { get; set; } = true;
     public int InboxCleanupDaysOld { get; set; } = 30;
     public string ImportantFolder { get; set; } = "Important";
@@ -174,6 +188,18 @@ public enum RuleAction
     MarkImportant
 }
 
+public class Email
+{
+    public int MessageIndex { get; set; }
+    public string? Folder { get; set; }
+    public string? MoveTo { get; set; }
+    public string? SenderName { get; set; }
+    public string? SenderEmailaddress { get; set; }
+    public DateTimeOffset Date { get; set; }
+    public string? Subject { get; set; }
+    public string? Body { get; set; }
+}
+
 public class EmailFlagOperation
 {
     public string SourceFolder { get; set; } = string.Empty;

src/MailZort/Program.cs

@@ -25,7 +25,7 @@ public List<RuleTrigger> ProcessEmailBatch(List<EmailReceivedEventArgs> emails)
 
         var stopwatch = System.Diagnostics.Stopwatch.StartNew();
         var triggers = new List<RuleTrigger>();
-        var enabledRules = _rules.Where(r => r.IsEnabled && (r.ExpressionType == ExpressionType.AllEmails || (r.FrozenValues ?? r.Values?.ToArray())?.Length > 0)).ToList();
+        var enabledRules = _rules.Where(r => r.IsEnabled && (r.ExpressionType == ExpressionType.AllEmails || r.Values?.Any() == true)).ToList();
 
         _logger.LogInformation("Processing batch of {EmailCount} emails against {RuleCount} rules",
             emails.Count, enabledRules.Count);

src/MailZort/Services/BatchRuleProcessor.cs

@@ -1,11 +1,9 @@
 using System.Collections.Concurrent;
-using System.Data;
 using MailKit;
 using MailKit.Net.Imap;
 using MailKit.Search;
 using MailKit.Security;
 using MimeKit;
-using ServiceStack.OrmLite;
 
 namespace MailZort.Services
 {
@@ -14,7 +12,6 @@ public class EmailMonitoringService : BackgroundService
     {
         private readonly ILogger<EmailMonitoringService> _logger;
         private readonly EmailSettings _config;
-        private readonly MailDb _mailDb;
         private ImapClient? _client;
         private CancellationTokenSource? _idleDoneSource;
         private volatile bool _newMessagesFlag = false;
@@ -33,13 +30,11 @@ public class EmailMonitoringService : BackgroundService
         public EmailMonitoringService(
             ILogger<EmailMonitoringService> logger,
             EmailSettings config,
-            MailDb mailDb,
             IEmailMover emailMover,
             IBatchRuleProcessor batchRuleProcessor)
         {
             _logger = logger;
             _config = config;
-            _mailDb = mailDb;
             _emailMover = emailMover;
             _batchRuleProcessor = batchRuleProcessor;
         }
@@ -563,12 +558,6 @@ private async Task ProcessSingleMoveOperationAsync(EmailMoveOperation moveOperat
                 // Perform the move
                 await sourceFolder.MoveToAsync(moveOperation.EmailIds, destinationFolder);
 
-                // Save to database if enabled
-                if (_config.StoreMovedMessages)
-                {
-                    SaveEmailsToDatabase(moveOperation.Emails);
-                }
-
                 _logger.LogInformation("📁 Moved {Count} emails from {Source} to {Destination}",
                     moveOperation.Emails.Count, moveOperation.SourceFolder, moveOperation.DestinationFolder);
             }
@@ -599,22 +588,6 @@ private IMailFolder GetDestinationFolder(string folderName)
             return _client!.GetFolder(folderName);
         }
 
-        private void SaveEmailsToDatabase(List<Email> emails)
-        {
-            using var dbConnection = _mailDb.GetConnection();
-            foreach (var email in emails)
-            {
-                try
-                {
-                    dbConnection.Insert(email);
-                }
-                catch (Exception ex)
-                {
-                    _logger.LogError(ex, "Error saving email {MessageIndex} to database", email.MessageIndex);
-                }
-            }
-        }
-
         private void OnCountChanged(object? sender, EventArgs e)
         {
             var folder = (IMailFolder)sender!;

src/MailZort/Services/EmailMonitoringService.cs

@@ -50,7 +50,7 @@ private bool ProcessMatch(Rule rule, EmailReceivedEventArgs email, string value,
 
         if (passesAge && passesStatus)
         {
-            var ruleValues = string.Join(", ", rule.FrozenValues ?? rule.Values?.ToArray() ?? Array.Empty<string>());
+            var ruleValues = string.Join(", ", rule.Values ?? new List<string>());
             _logger.LogInformation("RULE MATCHED! Rule: {RuleId}, Value: '{Value}', Location: {Location}, Subject: '{Subject}', RuleValues: [{RuleValues}]",
                 rule.Name, value, matchResult.MatchLocation, email.Subject, ruleValues);
             return true;
@@ -78,8 +78,7 @@ public bool CheckRuleMatch(Rule rule, EmailReceivedEventArgs email)
                 return false;
             }
         }
-        var valuesToCheck = rule.FrozenValues ?? rule.Values?.ToArray() ?? Array.Empty<string>();
-        foreach (var value in valuesToCheck)
+        foreach (var value in rule.Values!)
         {
             _logger.LogDebug("Testing value: '{Value}' with expression type: {ExpressionType}", value, rule.ExpressionType);
 

src/MailZort/Services/RuleMatcher.cs

@@ -3,7 +3,7 @@
         "Trash": "Deleted Messages",
         "StoreMovedMessages": false
     },
-    "rules": [
+    "Rules": [
         {
             "Name": "Shipping",
             "Folder": "Inbox",