Fixes #916

 1. User creates a review in HRPerformanceReviews.php
 - Selects an optional Rating Scale from dropdown
 - Scale is saved to hrperformancereviews.scaleid
 2. User enters ratings in HRPerformanceRatings.php
 - System loads the review's associated rating scale
 - Rating dropdown is dynamically generated from scale's min/max values
 - Users rate using the custom scale (e.g., 1-10 or 1-3 instead of just 1-5)
 3. Backward Compatibility
 - If no scale is selected, defaults to 1-5 (original behavior)
 - Existing reviews without a scale still work
 - Scale field is optional

Files changed in commit:
HRPerformanceRatings.php
HRPerformanceReviews.php
sql/updates/61.php

Author: timschofield

HRPerformanceRatings.php

@@ -137,19 +137,21 @@
 	}
 }
 
-// Display rating form
+	// Display rating form
 if (isset($_GET['ReviewID']) || isset($_POST['ReviewID'])) {
 	$ReviewID = isset($_GET['ReviewID']) ? (int)$_GET['ReviewID'] : (int)$_POST['ReviewID'];
 
-	// Get review details
+	// Get review details with scale information
 	$SQL = "SELECT pr.*,
 				e.firstname, e.lastname, e.employeenumber,
 				d.description,
-				p.positiontitle
+				p.positiontitle,
+				hs.minvalue, hs.maxvalue
 			FROM hrperformancereviews pr
 			INNER JOIN hremployees e ON pr.employeeid = e.employeeid
 			LEFT JOIN departments d ON e.departmentid = d.departmentid
 			LEFT JOIN hrpositions p ON e.positionid = p.positionid
+			LEFT JOIN hrratingscales hs ON pr.scaleid = hs.scaleid
 			WHERE pr.reviewid = " . $ReviewID;
 	$Result = DB_query($SQL);
 	$ReviewRow = DB_fetch_array($Result);
@@ -229,13 +231,17 @@
 					<td class="number">' . number_format($Row['weight'], 1) . '%</td>
 					<td>
 						<select name="Rating_' . $Row['criteriaid'] . '" required="required">
-							<option value="">' . __('Select') . '</option>
-							<option value="5"' . ($ExistingRating == 5 ? ' selected="selected"' : '') . '>5 - ' . __('Outstanding') . '</option>
-							<option value="4"' . ($ExistingRating == 4 ? ' selected="selected"' : '') . '>4 - ' . __('Exceeds Expectations') . '</option>
-							<option value="3"' . ($ExistingRating == 3 ? ' selected="selected"' : '') . '>3 - ' . __('Meets Expectations') . '</option>
-							<option value="2"' . ($ExistingRating == 2 ? ' selected="selected"' : '') . '>2 - ' . __('Needs Improvement') . '</option>
-							<option value="1"' . ($ExistingRating == 1 ? ' selected="selected"' : '') . '>1 - ' . __('Unsatisfactory') . '</option>
-						</select>
+							<option value="">' . __('Select') . '</option>';
+
+			/* Use rating scale from review if available, otherwise default to 1-5 */
+			$MinRating = isset($ReviewRow['minvalue']) && $ReviewRow['minvalue'] !== NULL ? (int)$ReviewRow['minvalue'] : 1;
+			$MaxRating = isset($ReviewRow['maxvalue']) && $ReviewRow['maxvalue'] !== NULL ? (int)$ReviewRow['maxvalue'] : 5;
+
+			for ($i = $MaxRating; $i >= $MinRating; $i--) {
+				echo '<option value="' . $i . '"' . ($ExistingRating == $i ? ' selected="selected"' : '') . '>' . $i . '</option>';
+			}
+
+			echo '</select>
 					</td>
 					<td><input type="text" name="Comments_' . $Row['criteriaid'] . '" value="' . htmlspecialchars($ExistingComments) . '" size="50" /></td>
 				</tr>';
@@ -251,10 +257,14 @@
 
 		echo '</div>';
 
-		// Display existing overall score if available
+		/* Display existing overall score if available */
 		if ($ReviewRow['overallscore'] > 0) {
+			$MinRating = isset($ReviewRow['minvalue']) && $ReviewRow['minvalue'] !== NULL ? (int)$ReviewRow['minvalue'] : 1;
+			$MaxRating = isset($ReviewRow['maxvalue']) && $ReviewRow['maxvalue'] !== NULL ? (int)$ReviewRow['maxvalue'] : 5;
+			$MaxPossibleScore = $MaxRating;
+
 			echo '<div style="margin-top: 20px; padding: 15px; background-color: #c8e6c9; border: 1px solid #4caf50;">
-					<h3>' . __('Current Overall Score') . ': ' . number_format($ReviewRow['overallscore'], 2) . ' / 5.00</h3>
+					<h3>' . __('Current Overall Score') . ': ' . number_format($ReviewRow['overallscore'], 2) . ' / ' . number_format($MaxPossibleScore, 2) . '</h3>
 				</div>';
 		}
 

HRPerformanceReviews.php

@@ -49,6 +49,7 @@
 						reviewercomments = '" . $_POST['ReviewerComments'] . "',
 						employeecomments = '" . $_POST['EmployeeComments'] . "',
 						nextreviewdate = " . $NextReviewDate . ",
+						scaleid = " . (isset($_POST['ScaleID']) && (int)$_POST['ScaleID'] > 0 ? (int)$_POST['ScaleID'] : 'NULL') . ",
 						modifiedby = '" . $_SESSION['UserID'] . "',
 						modifieddate = NOW()
 					WHERE reviewid = " . (int)$_POST['ReviewID'];
@@ -64,7 +65,7 @@
 						reviewerid, overallrating, reviewtype, status,
 						strengths, areasforimprovement, goals,
 						reviewercomments, employeecomments, nextreviewdate,
-						createdby, createddate
+						scaleid, createdby, createddate
 					) VALUES (
 						" . (int)$_POST['EmployeeID'] . ",
 						'" . $ReviewDate . "',
@@ -80,6 +81,7 @@
 						'" . $_POST['ReviewerComments'] . "',
 						'" . $_POST['EmployeeComments'] . "',
 						" . $NextReviewDate . ",
+						" . (isset($_POST['ScaleID']) && (int)$_POST['ScaleID'] > 0 ? (int)$_POST['ScaleID'] : 'NULL') . ",
 						'" . $_SESSION['UserID'] . "',
 						NOW()
 					)";
@@ -119,6 +121,7 @@
 	$ReviewerComments = '';
 	$EmployeeComments = '';
 	$NextReviewDate = '';
+	$ScaleID = 0;
 
 	if ($ReviewID > 0) {
 		$SQL = "SELECT * FROM hrperformancereviews WHERE reviewid = " . $ReviewID;
@@ -139,6 +142,7 @@
 			$ReviewerComments = $Row['reviewercomments'];
 			$EmployeeComments = $Row['employeecomments'];
 			$NextReviewDate = ConvertSQLDate($Row['nextreviewdate']);
+			$ScaleID = $Row['scaleid'];
 		}
 	}
 
@@ -216,6 +220,22 @@
 				</select>
 			</field>
 
+			<field>
+				<label for="ScaleID">' . __('Rating Scale') . ':</label>
+				<select name="ScaleID">
+					<option value="">' . __('Select Rating Scale (Optional)') . '</option>';
+
+	$SQL = "SELECT scaleid, scalename FROM hrratingscales WHERE active = 1 ORDER BY scalename";
+	$Result = DB_query($SQL);
+	while ($Row = DB_fetch_array($Result)) {
+		echo '<option value="' . $Row['scaleid'] . '"' .
+			($ScaleID == $Row['scaleid'] ? ' selected="selected"' : '') .
+			'>' . htmlspecialchars($Row['scalename'], ENT_QUOTES, 'UTF-8') . '</option>';
+	}
+
+	echo '</select>
+			</field>
+
 			<field>
 				<label for="OverallRating">' . __('Overall Rating') . ':</label>
 				<select name="OverallRating" required="required">
@@ -315,7 +335,7 @@
 
 			<hr style="margin: 20px 0;" />
 
-			<h3>' . __('Overall Rating') . ': <span style="color: #d32f2f;">' . __($ReviewRow['overallrating']) . '</span></h3>
+			<h3>' . __('Overall Rating') . ': <span style="color: #d32f2f;">' . htmlspecialchars($ReviewRow['overallrating'], ENT_QUOTES, 'UTF-8') . '</span></h3>
 
 			<h3>' . __('Key Strengths') . '</h3>
 			<p style="white-space: pre-wrap; padding: 10px; background-color: white; border: 1px solid #ccc;">' . htmlspecialchars($ReviewRow['strengths']) . '</p>
@@ -443,7 +463,7 @@
 					<td>' . ConvertSQLDate($Row['reviewdate']) . '</td>
 					<td>' . ConvertSQLDate($Row['reviewperiodstart']) . ' to ' . ConvertSQLDate($Row['reviewperiodend']) . '</td>
 					<td>' . __($Row['reviewtype']) . '</td>
-					<td><strong>' . __($Row['overallrating']) . '</strong></td>
+					<td><strong>' . htmlspecialchars($Row['overallrating'], ENT_QUOTES, 'UTF-8') . '</strong></td>
 					<td>' . ($Row['reviewerfirstname'] ? $Row['reviewerfirstname'] . ' ' . $Row['reviewerlastname'] : '-') . '</td>
 					<td>' . __($Row['status']) . '</td>
 					<td>

sql/updates/61.php

@@ -0,0 +1,13 @@
+<?php
+
+/* Add rating scale support to performance reviews */
+
+$SQL = "ALTER TABLE hrperformancereviews
+		ADD COLUMN scaleid INT(11) DEFAULT NULL,
+		ADD CONSTRAINT fk_review_scale FOREIGN KEY (scaleid) REFERENCES hrratingscales (scaleid) ON DELETE SET NULL";
+
+DB_query($SQL, __('Failed to add scaleid to hrperformancereviews'));
+
+if ($_SESSION['Updates']['Errors'] == 0) {
+	UpdateDBNo(basename(__FILE__, '.php'), __('Add rating scale support to performance reviews'));
+}