Skip to content
This repository was archived by the owner on Mar 30, 2022. It is now read-only.
This repository was archived by the owner on Mar 30, 2022. It is now read-only.

Vertical slider doesn't draw correctly in disabled state (patch included) #56

@garethsb-ghost

Description

@garethsb-ghost

BGHUDAppKit looks great. Thank you, Tim!

BGHUDSliderCell doesn't draw a vertical slider correctly in the disabled state. I think this is just an oversight and easily fixed by applying the code from the horizontal variant:

diff /Users/garethsb/Development/binarygod-BGHUDAppKit-79a560d/Framework/BGHUDSliderCell.m /Users/garethsb/Development/binarygod-BGHUDAppKit-79a560d-patched/Framework/BGHUDSliderCell.m 
308,312c308,322
<    [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] sliderTrackColor] set];
<    [path fill];
<    
<    [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] strokeColor] set];
<    [path stroke];

---
>    if([self isEnabled]) {
>        
>        [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] sliderTrackColor] set];
>        [path fill];
>        
>        [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] strokeColor] set];
>        [path stroke];
>    } else {
>        
>        [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] disabledSliderTrackColor] set];
>        [path fill];
>        
>        [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] disabledStrokeColor] set];
>        [path stroke];
>    }

Thanks,
Gareth Sylvester-Bradley

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions