refactor: large maintainability + correctness pass

Codebase audit and cleanup across most of elle-app. Highlights:

- Extract useUnits/useNumberEntry/useAxisOffsets/useJog/ParameterButton/PresetGrid
  and split g-code math into gcode/threading.ts and gcode/turning.ts with tests
- Store canned-cycle values in canonical mm; delete convertThreading/Turning
- Centralize HAL URLs + constants in frontend/src/config.ts (env-var overridable)
- Surface HAL connection failures + settings-save errors via UI banners
- Type HAL API end-to-end (HalOut, ThreadingRequest, TurningRequest);
  distinguish 4xx (silent) from 5xx/network (banner trips)
- Centralize settings schema so adding a field only touches one place
- Upgrade all deps to latest (electron 36->41, vite 6->8, vitest 2->4,
  typescript 5->6, vue-router 4->5); fix moduleResolution deprecations
- Remove dead deps (@apollo/server, graphql, electron-log, electron-updater)
  and unused Iosevka font variants (~22MB reclaimed)
- Add yarn verify pipeline (typecheck + eslint + prettier + vitest) with
  pre-commit hook, GitHub Actions CI, and 64 tests

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: tinic

.github/workflows/ci.yml

@@ -0,0 +1,45 @@
+name: verify
+
+on:
+  push:
+    branches: [main]
+  pull_request:
+    branches: [main]
+
+jobs:
+  verify:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Set up Node 22
+        uses: actions/setup-node@v4
+        with:
+          node-version: 22
+
+      - name: Install yarn
+        run: npm install --global yarn
+
+      - name: Install root deps
+        run: cd elle-app && yarn install --frozen-lockfile
+
+      - name: Install frontend deps
+        run: cd elle-app/elle-frontend && yarn install --frozen-lockfile
+
+      - name: Typecheck
+        run: cd elle-app && yarn typecheck
+
+      - name: Lint
+        run: cd elle-app && yarn lint
+
+      - name: Prettier check
+        run: cd elle-app && yarn format:check
+
+      - name: Tests
+        run: cd elle-app && yarn test
+
+      - name: Frontend build
+        run: cd elle-app && yarn build:front
+
+      - name: Electron build
+        run: cd elle-app && yarn build

elle-app/.husky/pre-commit

@@ -0,0 +1 @@
+cd elle-app && yarn lint-staged

elle-app/.prettierignore

@@ -0,0 +1,9 @@
+node_modules
+dist
+build
+elle-frontend/node_modules
+elle-frontend/public
+elle-hal
+yarn.lock
+*.min.js
+*.min.css

elle-app/.prettierrc

@@ -0,0 +1,6 @@
+{
+  "singleQuote": true,
+  "semi": false,
+  "trailingComma": "none",
+  "printWidth": 100
+}

elle-app/elle-electron/config.ts

@@ -1 +1,5 @@
 export const isDev = process.env.APP_IS_DEV ? true : false
+
+// Window sizing for the touch-screen target display
+export const WINDOW_WIDTH = 1366
+export const WINDOW_HEIGHT = 768

elle-app/elle-electron/electron-store/configuration.ts

@@ -1,32 +1,48 @@
 import Store from 'electron-store'
 
-interface Tool {
+export interface Tool {
   id: number
   offsetX: number
   offsetZ: number
   description: string
 }
 
+export interface AppBounds {
+  x?: number
+  y?: number
+  width?: number
+  height?: number
+}
+
+export interface Settings {
+  appBounds?: AppBounds
+  diameterMode?: boolean
+  defaultMetricOnStartup?: boolean
+  selectedThreadingTab?: number
+  selectedTurningTab?: number
+  selectedPitchTab?: number[]
+  pitchX?: number
+  pitchZ?: number
+  encoderScaleZ?: number
+  encoderScaleX?: number
+  tools?: Tool[]
+  currentToolIndex?: number
+  currentToolOffsetX?: number
+  currentToolOffsetZ?: number
+}
+
 interface AppConfig {
-  setting: {
-    appBounds?: any
-    diameterMode?: boolean
-    defaultMetricOnStartup?: boolean
-    selectedThreadingTab?: number
-    selectedTurningTab?: number
-    selectedPitchTab?: number[]
-    pitchX?: number
-    pitchZ?: number
-    encoderScaleZ?: number
-    encoderScaleX?: number
-    tools?: Tool[]
-    currentToolIndex?: number
-    currentToolOffsetX?: number
-    currentToolOffsetZ?: number
-  }
+  setting: Settings
+}
+
+// electron-store's Store#get/set are typed on top-level keys only, so we cast
+// to `Record<string, unknown>` to reach nested `setting.xxx` dotted paths.
+type StoreAny = {
+  get: <T = unknown>(key: string, defaultValue?: T) => T
+  set: (key: string, value: unknown) => void
 }
 
-export const appConfig = new Store<AppConfig>({
+const rawStore = new Store<AppConfig>({
   name: 'appConfig',
   defaults: {
     setting: {
@@ -40,3 +56,5 @@ export const appConfig = new Store<AppConfig>({
     }
   }
 })
+
+export const appConfig = rawStore as unknown as StoreAny

elle-app/elle-electron/installDevTool.ts

@@ -1,7 +1,9 @@
-import installExtension, { VUEJS_DEVTOOLS } from 'electron-devtools-installer'
+import { installExtension, VUEJS_DEVTOOLS } from 'electron-devtools-installer'
 
 export async function installExt() {
-  await installExtension(VUEJS_DEVTOOLS)
-    .then(() => {})
-    .catch((_err) => {})
+  try {
+    await installExtension(VUEJS_DEVTOOLS)
+  } catch {
+    // ignore — dev tools install is best-effort
+  }
 }

elle-app/elle-electron/main.ts

@@ -6,9 +6,9 @@ const __filename = fileURLToPath(import.meta.url)
 const __dirname = path.dirname(__filename)
 
 import type { BrowserWindowConstructorOptions } from 'electron'
-import { app, BrowserWindow, ipcMain, screen, nativeTheme } from 'electron'
-import { isDev } from './config.js'
-import { appConfig } from './electron-store/configuration.js'
+import { app, BrowserWindow, ipcMain, screen } from 'electron'
+import { isDev, WINDOW_HEIGHT, WINDOW_WIDTH } from './config.js'
+import { appConfig, type AppBounds, type Settings } from './electron-store/configuration.js'
 import type { ChildProcess } from 'node:child_process'
 import { spawn, spawnSync } from 'node:child_process'
 
@@ -18,14 +18,14 @@ let halquit: boolean = false
 
 async function createWindow() {
   const { width, height } = screen.getPrimaryDisplay().workAreaSize
-  const appBounds: any = (appConfig as any).get('setting.appBounds')
+  const appBounds = appConfig.get<AppBounds | undefined>('setting.appBounds')
   const BrowserWindowOptions: BrowserWindowConstructorOptions = {
-    width: 1366,
-    minWidth: 1366,
-    height: 768,
-    minHeight: 768,
+    width: WINDOW_WIDTH,
+    minWidth: WINDOW_WIDTH,
+    height: WINDOW_HEIGHT,
+    minHeight: WINDOW_HEIGHT,
     webPreferences: {
-      preload: `${__dirname  }/preload.js`,
+      preload: `${__dirname}/preload.js`,
       devTools: false,
       nodeIntegration: false,
       contextIsolation: true
@@ -36,7 +36,9 @@ async function createWindow() {
     fullscreen: true
   }
 
-  if (appBounds !== undefined && appBounds !== null) {Object.assign(BrowserWindowOptions, appBounds)}
+  if (appBounds !== undefined && appBounds !== null) {
+    Object.assign(BrowserWindowOptions, appBounds)
+  }
   mainWindow = new BrowserWindow(BrowserWindowOptions)
 
   // Remove menu bar
@@ -53,11 +55,13 @@ async function createWindow() {
   if (
     appBounds !== undefined &&
     appBounds !== null &&
-    appBounds.width > width &&
-    appBounds.height > height
-  )
-  {mainWindow.maximize()}
-  else {mainWindow.show()}
+    (appBounds.width ?? 0) > width &&
+    (appBounds.height ?? 0) > height
+  ) {
+    mainWindow.maximize()
+  } else {
+    mainWindow.show()
+  }
 
   // this will turn off always on top after opening the application
   setTimeout(() => {
@@ -73,60 +77,26 @@ async function createWindow() {
   }))
 }
 
-// Settings handlers (global)
-ipcMain.handle('getSettings', () => ({
-  diameterMode: (appConfig as any).get('setting.diameterMode'),
-  defaultMetricOnStartup: (appConfig as any).get('setting.defaultMetricOnStartup'),
-  selectedThreadingTab: (appConfig as any).get('setting.selectedThreadingTab', 0),
-  selectedTurningTab: (appConfig as any).get('setting.selectedTurningTab', 0),
-  selectedPitchTab: (appConfig as any).get('setting.selectedPitchTab', [0, 0]),
-  pitchX: (appConfig as any).get('setting.pitchX', 0.0),
-  pitchZ: (appConfig as any).get('setting.pitchZ', 0.0),
-  encoderScaleZ: (appConfig as any).get('setting.encoderScaleZ', 0.001),
-  encoderScaleX: (appConfig as any).get('setting.encoderScaleX', -0.001),
-  tools: (appConfig as any).get('setting.tools'),
-  currentToolIndex: (appConfig as any).get('setting.currentToolIndex', 0),
-  currentToolOffsetX: (appConfig as any).get('setting.currentToolOffsetX', 0),
-  currentToolOffsetZ: (appConfig as any).get('setting.currentToolOffsetZ', 0)
-}))
-
-// IMPORTANT: This handler should save ALL settings passed from useSettings.ts
-// If you add new settings, make sure they're included both here AND in useSettings.ts
-// Do NOT create duplicate save logic elsewhere - use the useSettings saveSettings function
-ipcMain.handle('saveSettings', (event, settings) => {
-  const currentSettings = (appConfig as any).get('setting', {})
-  ;(appConfig as any).set('setting', {
-    ...currentSettings,
-    diameterMode: settings.diameterMode,
-    defaultMetricOnStartup: settings.defaultMetricOnStartup,
-    selectedThreadingTab: settings.selectedThreadingTab,
-    selectedTurningTab: settings.selectedTurningTab,
-    selectedPitchTab: settings.selectedPitchTab,
-    pitchX: settings.pitchX,
-    pitchZ: settings.pitchZ,
-    encoderScaleZ: settings.encoderScaleZ,
-    encoderScaleX: settings.encoderScaleX,
-    tools: settings.tools,
-    currentToolIndex: settings.currentToolIndex,
-    currentToolOffsetX: settings.currentToolOffsetX,
-    currentToolOffsetZ: settings.currentToolOffsetZ
-  })
+// Settings handlers — transparent passthrough.
+// The schema (fields + defaults) lives in elle-frontend/src/composables/useSettings.ts.
+// This handler just reads/writes the `setting` blob so adding a new field only touches one file.
+ipcMain.handle('getSettings', () => appConfig.get<Settings>('setting', {} as Settings))
+
+ipcMain.handle('saveSettings', (_event, settings: Settings) => {
+  const current = appConfig.get<Settings>('setting', {} as Settings)
+  appConfig.set('setting', { ...current, ...settings })
   return true
 })
 
 app.commandLine.appendSwitch('gtk-version', '3')
 
 app.whenReady().then(async () => {
-  // Force dark mode for the entire application
-  nativeTheme.themeSource = 'dark'
-  
   if (isDev) {
     try {
       const { installExt } = await import('./installDevTool.js')
       await installExt()
-    // eslint-disable-next-line @typescript-eslint/no-unused-vars
-    } catch (_e) {
-      // Ignore errors during dev tool installation
+    } catch {
+      // best-effort: dev tools are optional
     }
   }
   createWindow()
@@ -173,13 +143,13 @@ ipcMain.on('quit', () => {
 })
 
 ipcMain.on('startHAL', () => {
-  const hal_path = `${process.cwd()  }/elle-hal`
-  const halfile_path = `${process.cwd()  }/elle-hal/lathe.hal`
+  const hal_path = `${process.cwd()}/elle-hal`
+  const halfile_path = `${process.cwd()}/elle-hal/lathe.hal`
   if (fs.existsSync(halfile_path)) {
     try {
       cleanMess()
       const env = process.env
-      env.PATH += `:${  hal_path}`
+      env.PATH += `:${hal_path}`
       halrun = spawn('unbuffer', ['linuxcnc', 'lathe.ini'], { cwd: hal_path, env: env })
       halrun.stdout?.on('data', (stdout: Buffer) => {
         mainWindow.webContents.send('halStdout', stdout.toString())
@@ -190,7 +160,7 @@ ipcMain.on('startHAL', () => {
       halrun.stderr?.on('data', (stderr: Buffer) => {
         mainWindow.webContents.send('halStdout', stderr.toString())
       })
-      halrun.on('exit', (_code: any) => {
+      halrun.on('exit', () => {
         mainWindow.webContents.send('halStopped')
         cleanMess()
         if (halquit) {

elle-app/elle-electron/preload.d.ts

@@ -1,6 +1,6 @@
 declare interface api {
-  send: (channel: any, data: any) => void
-  receive: (channel: any, func: any) => void
+  send: (channel: string, data?: unknown) => void
+  receive: (channel: string, func: (...args: unknown[]) => void) => void
 }
 
 declare interface Tool {
@@ -10,7 +10,26 @@ declare interface Tool {
   description: string
 }
 
+// This shape must match the DEFAULTS object in elle-frontend/src/composables/useSettings.ts.
+// The frontend is the source of truth for the schema; this declaration is a runtime
+// handshake for the preload bridge.
+declare interface AppSettings {
+  diameterMode: boolean
+  defaultMetricOnStartup: boolean
+  selectedThreadingTab: number
+  selectedTurningTab: number
+  selectedPitchTab: number[]
+  pitchX: number
+  pitchZ: number
+  encoderScaleZ: number
+  encoderScaleX: number
+  tools: Tool[]
+  currentToolIndex: number
+  currentToolOffsetX: number
+  currentToolOffsetZ: number
+}
+
 declare interface settings {
-  get: () => Promise<{ diameterMode: boolean; defaultMetricOnStartup: boolean; selectedThreadingTab: number; selectedTurningTab: number; selectedPitchTab: number[]; pitchX: number; pitchZ: number; encoderScaleZ: number; encoderScaleX: number; tools?: Tool[]; currentToolIndex?: number; currentToolOffsetX?: number; currentToolOffsetZ?: number }>
-  save: (settings: { diameterMode: boolean; defaultMetricOnStartup: boolean; selectedThreadingTab: number; selectedTurningTab: number; selectedPitchTab: number[]; pitchX: number; pitchZ: number; encoderScaleZ: number; encoderScaleX: number; tools?: Tool[]; currentToolIndex?: number; currentToolOffsetX?: number; currentToolOffsetZ?: number }) => Promise<boolean>
+  get: () => Promise<AppSettings>
+  save: (settings: AppSettings) => Promise<boolean>
 }

elle-app/elle-electron/preload.ts

@@ -1,25 +1,26 @@
 import { contextBridge, ipcRenderer } from 'electron'
+import type { Settings } from './electron-store/configuration.js'
 
 contextBridge.exposeInMainWorld('browserWindow', {
   versions: () => ipcRenderer.invoke('versions')
 })
 
 contextBridge.exposeInMainWorld('settings', {
   get: () => ipcRenderer.invoke('getSettings'),
-  save: (settings: any) => ipcRenderer.invoke('saveSettings', settings)
+  save: (settings: Settings) => ipcRenderer.invoke('saveSettings', settings)
 })
 
 contextBridge.exposeInMainWorld('api', {
-  send: (channel: any, data: any) => {
+  send: (channel: string, data?: unknown) => {
     const validChannels = ['startHAL', 'stopHAL', 'quit']
     if (validChannels.includes(channel)) {
       ipcRenderer.send(channel, data)
     }
   },
-  receive: (channel: any, func: any) => {
+  receive: (channel: string, func: (...args: unknown[]) => void) => {
     const validChannels = ['halStarted', 'halStopped', 'halStdout']
     if (validChannels.includes(channel)) {
-      ipcRenderer.on(channel, (event, ...args) => func(...args))
+      ipcRenderer.on(channel, (_event, ...args) => func(...args))
     }
   }
 })