Support array factories and explicit null-only filter compilation.#45
Merged
gustavofreze merged 1 commit intomainfrom Apr 21, 2026
Merged
Support array factories and explicit null-only filter compilation.#45gustavofreze merged 1 commit intomainfrom
gustavofreze merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the tiny-blocks Collection library to better support closure-based factories that return arrays, while tightening up predicate compilation behavior and normalizing project metadata/tooling.
Changes:
- Allow
EagerPipeline::fromClosure()to accept either anarrayor aTraversableresult from the factory. - Make
Filterpredicate compilation explicitly drop onlynullpredicates. - Normalize/refresh project metadata and contributor tooling/docs (Composer normalization, README overview, editor config, Claude rules).
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Internal/Operations/Transforming/Filter.php | Filters out only null predicates before compiling the combined predicate. |
| src/Internal/EagerPipeline.php | Handles array-returning factories in fromClosure() to support array factories. |
| composer.json | Updates package description/structure and adds Composer normalization tooling/config. |
| README.md | Refreshes the library overview wording to align with current design (eager/lazy pipelines, generators). |
| Makefile | Runs composer normalize during make configure. |
| .editorconfig | Adds consistent formatting rules across the repo. |
| .claude/rules/php-library-testing.md | Adjusts rule formatting and updates references to renamed rule files. |
| .claude/rules/php-library-modeling.md | Introduces consolidated library modeling rules. |
| .claude/rules/php-library-documentation.md | Adjusts rule formatting and clarifies documentation expectations for examples. |
| .claude/rules/php-library-code-style.md | Updates/clarifies code style rules (including complexity + naming guidance). |
| .claude/rules/php-domain.md | Removes superseded domain rules file. |
| .claude/CLAUDE.md | Updates project description to match this repo being a library package. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.