Merge pull request #64 from foodtiny/java.util.ArrayList

Refactor foreach ArrayList

Author: thuydunq

.gitignore

@@ -23,4 +23,3 @@
 /logging
 /json
 /native.iml
-

java/lang/String/String.hpp

@@ -55,6 +55,7 @@ namespace Java {
 			String(Array<byte> &bytes);
 			String(const String &target);
 			~String();
+
 		public:
 			char charAt(int index);
 

java/util/ArrayList/ArrayList.hpp

@@ -47,45 +47,27 @@ using namespace Java::Util::Function;
 
 namespace Java {
 	namespace Util {
-		template <typename E>
-		class ArrayList;
-		
-		template <typename E>
-		class ArrayListIterator {
-		public:
-			ArrayListIterator(const ArrayList<E> *p_vec, int pos) : _pos(pos), _p_vec(p_vec) {
-
-			}
-
-			boolean operator!=(const ArrayListIterator<E> &other) const {
-				return _pos != other._pos;
-			}
-
-			int operator*() const {
-				return _p_vec->get(_pos);
-			}
-
-			const ArrayListIterator<E> &operator++() {
-				++_pos;
-				return *this;
-			}
-
-		private:
-			int _pos;
-			const ArrayList<E> *_p_vec;
-		};
 		template <typename E>
 		class ArrayList :
 			public virtual AbstractList<E>,
 			public virtual Serializable,
 			public virtual Cloneable,
-			// public virtual List<E>,
+//			 public virtual List<E>,
 			public virtual RandomAccess {
 		private:
 			std::vector<E> original;
+            typedef E* _iterator;
+            typedef const E* _const_iterator;
+
 
 		public:
-			/**
+
+            _iterator begin() { return &this->original[0]; };
+            _const_iterator begin() const { return &this->original[0]; };
+            _iterator end() { return &this->original[this->original.size()]; };
+            _const_iterator end() const { return &this->original[this->original.size()]; };
+
+            /**
 			 * Constructs an empty list
 			 */
 			ArrayList() {
@@ -117,22 +99,6 @@ namespace Java {
 
 			}
 
-		public:
-			/**
-			 * @return
-			 */
-			ArrayListIterator<E> begin() const {
-				return ArrayListIterator<E>(this, 0);
-			}
-
-			/**
-			 *
-			 * @return
-			 */
-			ArrayListIterator<E> end() const {
-				return original.end();
-			}
-
 		public:
 
 			/**

java/util/ArrayList/ArrayListTest.cpp

@@ -95,3 +95,19 @@ TEST(Javalang, ArrayListFunction) {
     ASSERT_EQUAL(0 ,intArray.get(-1));
     ASSERT_EQUAL(5 ,intArray.get(intArray.size()));
 }
+
+TEST(JavaLang, ArrayListForEach) {
+    //
+    ArrayList<int> validArrayList;
+
+    int index;
+    for (index = 0; index < 100; ++index) {
+        validArrayList.add(index);
+    }
+
+    int expect = 0;
+    for (int element : validArrayList) {
+        ASSERT_EQUAL(expect, element);
+        expect++;
+    }
+}