Merge pull request #68 from foodtiny/task/fix-memory-leak

Task/fix memory leak

Author: loint

.gitignore

@@ -1,5 +1,6 @@
 # git rm --cached `git ls-files -i --exclude-from=.gitignore`
 .DS_Store
+bin
 /.idea
 /CMakeFiles
 /cmake-build-debug
@@ -22,4 +23,4 @@
 /test.txt
 /logging
 /json
-/native.iml
+/native.iml

.travis.yml

@@ -20,5 +20,4 @@ after_script:
 after_success:
 - ./misc/memory_check
 notifications:
-  slack:
-    secure: o9QdIW3+j/aNslgHg11smJ1lDraArvCx+WT0ySqp6bXW0OYrQgG/JX6AxMhtNieGq7DnSFVKJgZFLr9B8VyqjiKRK6pseNXF0XhcxtS2fMsx/1kHYYmkzaiQZgntG0ZqMCvHbvRHucfzLHAyMGX0W8/E2BHnFvNXE9zXNLMzNTIZbigIV3BUcPvM/hkxw9DJ1KLJtm94uoszqFn10Y2joWQqJ6HAlGJrirLzgLSuUjE9mvKDBk9udnOpHFE22FPaj8aICYAJRTKtSvM4t8JO1W78bnuPjZf/GzHnkKC/O2EpE8L1WVOevJxJw889mLmTjWMICNVmB7wF14UOQpDTwQeDyvuDUtxx5V9TU0AuhfPO6TpThcymnHh/6CFjtJHmtHCTMLfR2HXCu3F6dv4C/OJeKVtjcoxbKn+mvyHOmiuU8dxc+BdbEfJngQj7jskJVssGbNZJ/3dlWmkzcw99l4t4MSNPTICWXw4Di2UwL8knpDwYvjPIlotU1uJH9YpaVO7ub8bClX9p75ajLac8bEE42rL1722vthMqVlD+3bIxJVuXG/Ri5dhKUoBciEKcBNMzOEs4x3yKSFvKc7NF9Fwwl1OL+L47HpJ2NceCrSKwCO9qKBDS9Ck1CHzs8ikl6UMp+Gpd1h7veBV7atIhyaXubIVDdthzoD3+U1gFT/0=
+  slack: foodtiny:hzkLBCLrqjtgi9ctqwdQ034S

CMakeLists.txt

@@ -98,7 +98,7 @@ set(DYLD_LIBRARY_PATH ${DYLD_LIBRARY_PATH})
 file(GLOB_RECURSE HEADERS
         ./*.h
         library.hpp
-)
+        )
 
 # Include all C/C++ and Unix Assembly files
 file(GLOB_RECURSE SOURCES_C
@@ -110,11 +110,12 @@ file(GLOB_RECURSE SOURCES_C
         server/*
         storage/*
         string/*
+        system/*
         thread/*
         type/*
         vendor/*
         validator/*
-)
+        )
 
 # Include all C unit test cases
 file(GLOB_RECURSE TESTS_C
@@ -126,11 +127,12 @@ file(GLOB_RECURSE TESTS_C
         server/*_test.c
         storage/*_test.c
         string/*_test.c
+        system/*_test.c
         thread/*_test.c
         type/*_test.c
         vendor/*_test.c
         validator/*_test.c
-)
+        )
 
 # Remove all test files within c files
 foreach (test_c_file ${TESTS_C})
@@ -140,12 +142,12 @@ endforeach ()
 # Only C++ unit test files
 file(GLOB_RECURSE SOURCES_CPP
         java/**/*.cpp
-)
+        )
 
 # Only C++ unit test files
 file(GLOB_RECURSE TESTS_CPP
         java/**/*Test.cpp
-)
+        )
 
 # Remove all test files within cpp files
 foreach (test_cpp_file ${TESTS_CPP})
@@ -175,7 +177,7 @@ add_custom_target(
 # Check memory leak
 add_custom_target(
         leak
-        COMMAND valgrind --track-origins=yes --error-exitcode=2 --show-leak-kinds=all --leak-check=full ./native_test
+        COMMAND valgrind --track-origins=yes --error-exitcode=2 --leak-check=full ./native_test
 )
 
 # Check memory leak
@@ -186,8 +188,8 @@ add_custom_target(
 
 # Check memory leak
 add_custom_target(
-    leak-c
-    COMMAND valgrind --track-origins=yes --error-exitcode=2 --show-leak-kinds=all --leak-check=full ./native_test_c
+        leak-c
+        COMMAND valgrind --track-origins=yes --error-exitcode=2  --leak-check=full ./native_test_c
 )
 
 # Check memory leak
@@ -203,6 +205,13 @@ install(FILES ${HEADERS} DESTINATION include/native)
 install(DIRECTORY java DESTINATION include/native)
 install(FILES ${HEADERS} DESTINATION include/native)
 
+# Add uninstall
+add_custom_target(
+        uninstall
+        COMMAND rm -rf /usr/local/include/native
+        COMMAND rm -rf /usr/local/lib/libnative*
+)
+
 # Link library for OSX and other platform
 # Darwin platform no need to link realtime library (-lrt)
 if (${CMAKE_SYSTEM_NAME} MATCHES "Darwin")

README.md

@@ -7,10 +7,11 @@
 
 Beside standard library, we would like to have a greater customization with important goals:
 
-- Blazing fast performance and low-level access with GAS & C
+- Blazing fast performance with small footprint and low-level access with GAS & C
 - Powerful structured programming in C++ for scalability
 - Awesome syntactically enhancement with C++ customization
 - Java standard packages for productivity & maintainability
+- Reduce memory leak via automatic storage and object oriented instead of pointer
 - Support third-party services for business features
 
 This project is also useful for new developers in practical programming.

common/segment.c

@@ -38,7 +38,7 @@ inline char *segment_pointer_char(char *target_param, int from, int to) {
                 return strdup("");
         }
         char *target = strdup(target_param);
-        int length= to - from + 1;
+        int length = to - from + 1;
         if (to >= length_target) {
                 length = length_target - from + 1;
         }

common/sort_test.c

@@ -30,7 +30,7 @@
 
 TEST (Common, QuickSort) {
 	srand(time(NULL));
-	int *array_int = malloc(50 * sizeof(int));
+	int *array_int = calloc(50, sizeof(int));
 	int index;
 	for (index = 0; index < 50; ++index) {
 		array_int[ index ] = rand();

compress/miniz.c

@@ -612,7 +612,7 @@ typedef unsigned char mz_validate_uint64[sizeof(mz_uint64) == 8 ? 1 : -1];
   #define MZ_FREE(x) x, ((void)0)
   #define MZ_REALLOC(p, x) NULL
 #else
-#define MZ_MALLOC(x) malloc(x)
+#define MZ_MALLOC(x) calloc(x, sizeof(char))
 #define MZ_FREE(x) free(x)
 #define MZ_REALLOC(p, x) realloc(p, x)
 #endif

crypto/base64.c

@@ -18,7 +18,7 @@ base64_encode(const unsigned char *src, size_t len) {
 	unsigned char tmp[3];
 
 	// alloc
-	enc = (char *) malloc(0);
+	enc = (char *) calloc(0, sizeof(char));
 	if (NULL == enc) {
 		return NULL;
 	}
@@ -105,7 +105,7 @@ base64_decode_ex(const char *src, size_t len, size_t *decsize) {
 	unsigned char tmp[4];
 
 	// alloc
-	dec = (unsigned char *) malloc(0);
+	dec = (unsigned char *) calloc(0, sizeof(unsigned char));
 	if (NULL == dec) {
 		return NULL;
 	}

example/HelloWorld/Main.cpp

@@ -0,0 +1,8 @@
+#include <native/library.hpp>
+#include "Person.hpp"
+int main()
+{
+	Person person;
+	person.setFirstName("First name");
+	return 0;
+}

example/HelloWorld/Makefile

@@ -0,0 +1,5 @@
+all:
+	mkdir -p bin
+	g++ -c -std=c++11 -o bin/main.o Main.cpp
+	gcc -o bin/main bin/main.o /usr/local/lib/libnative.so -lstdc++
+	./bin/main