Skip to content

Commit cfc22ab

Browse files
committed
resolve conflict after merge development into this branch
2 parents 60aa3bf + 8302a95 commit cfc22ab

4 files changed

Lines changed: 27 additions & 18 deletions

File tree

.gitignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,4 +23,3 @@
2323
/logging
2424
/json
2525
/native.iml
26-

java/lang/String/String.hpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ namespace Java {
5555
String(Array<byte> &bytes);
5656
String(const String &target);
5757
~String();
58+
5859
public:
5960
char charAt(int index);
6061

java/util/ArrayList/ArrayList.hpp

Lines changed: 10 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -83,9 +83,18 @@ namespace Java {
8383
public virtual RandomAccess {
8484
private:
8585
std::vector<E> original;
86+
typedef E* _iterator;
87+
typedef const E* _const_iterator;
88+
8689

8790
public:
88-
/**
91+
92+
_iterator begin() { return &this->original[0]; };
93+
_const_iterator begin() const { return &this->original[0]; };
94+
_iterator end() { return &this->original[this->original.size()]; };
95+
_const_iterator end() const { return &this->original[this->original.size()]; };
96+
97+
/**
8998
* Constructs an empty list
9099
*/
91100
ArrayList() {
@@ -115,22 +124,6 @@ namespace Java {
115124

116125
}
117126

118-
public:
119-
/**
120-
* @return
121-
*/
122-
ArrayListIterator<E> begin() const {
123-
return ArrayListIterator<E>(this, 0);
124-
}
125-
126-
/**
127-
*
128-
* @return
129-
*/
130-
ArrayListIterator<E> end() const {
131-
return original.end();
132-
}
133-
134127
public:
135128

136129
/**

java/util/ArrayList/ArrayListTest.cpp

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,3 +95,19 @@ TEST(Javalang, ArrayListFunction) {
9595
ASSERT_EQUAL(0 ,intArray.get(-1));
9696
ASSERT_EQUAL(5 ,intArray.get(intArray.size()));
9797
}
98+
99+
TEST(JavaLang, ArrayListForEach) {
100+
//
101+
ArrayList<int> validArrayList;
102+
103+
int index;
104+
for (index = 0; index < 100; ++index) {
105+
validArrayList.add(index);
106+
}
107+
108+
int expect = 0;
109+
for (int element : validArrayList) {
110+
ASSERT_EQUAL(expect, element);
111+
expect++;
112+
}
113+
}

0 commit comments

Comments
 (0)