Skip to content

Commit f3da6db

Browse files
author
Food Tiny
authored
Merge pull request #324 from foodtiny/development
Update patch for String::trim()
2 parents cc65a35 + 65ceb83 commit f3da6db

2 files changed

Lines changed: 6 additions & 0 deletions

File tree

library/Java/Lang/String/String.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -433,6 +433,7 @@ String String::toUpperCase() {
433433
String String::trim() {
434434
size_t first = this->original.find_first_not_of(' ');
435435
if (std::string::npos == first) {
436+
this->original = "";
436437
return *this;
437438
}
438439
size_t last = this->original.find_last_not_of(' ');

library/Java/Lang/String/StringTest.cpp

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -895,6 +895,11 @@ TEST (JavaLangString, Trim) {
895895
assertEquals("THIS IS A CAT", trimUpperCase.trim().toUpperCase());
896896
}
897897

898+
{
899+
String allSpaceString = " ";
900+
assertEquals("", allSpaceString.trim());
901+
}
902+
898903
{
899904
String emptyString = "";
900905
assertEquals("", emptyString.trim());

0 commit comments

Comments
 (0)