fix: cleanup and do not accept empty versions and heartbeats

Author: steveiliop56

database/queries/query.sql.go

@@ -5,6 +5,7 @@ import (
 	"errors"
 	"log/slog"
 	"net/http"
+	"strings"
 	"time"
 
 	"github.com/steveiliop56/tinyauth-analytics/database/queries"
@@ -60,6 +61,15 @@ func (h *InstancesHandler) Heartbeat(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
+	if strings.TrimSpace(heartbeat.UUID) == "" || strings.TrimSpace(heartbeat.Version) == "" {
+		w.WriteHeader(http.StatusBadRequest)
+		render.JSON(w, r, map[string]string{
+			"status":  "400",
+			"message": "Invalid request payload",
+		})
+		return
+	}
+
 	_, err = h.queries.GetInstance(r.Context(), heartbeat.UUID)
 
 	if err != nil && !errors.Is(err, sql.ErrNoRows) {

instances_handler.go

@@ -116,7 +116,7 @@ func cleanUpOldInstances(queries *queries.Queries) {
 	ticker := time.NewTicker(24 * time.Hour)
 	defer ticker.Stop()
 
-	for ; true; <-ticker.C {
+	for range ticker.C {
 		slog.Info("cleaning up old instances")
 
 		cutoffTime := time.Now().Add(-48 * time.Hour).UnixMilli()

main.go

@@ -23,5 +23,5 @@ WHERE uuid = ?;
 
 -- name: DeleteOldInstances :many
 DELETE FROM instances
-WHERE last_seen < ?
-RETURNING *;
+WHERE last_seen < ? OR version = '' OR uuid = ''
+RETURNING *;