Skip to content

Commit 373ee88

Browse files
committed
chore: prefer errors.is instead of comparison
1 parent a14d64c commit 373ee88

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

internal/controller/oidc_controller.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -429,7 +429,7 @@ func (controller *OIDCController) Userinfo(c *gin.Context) {
429429
entry, err := controller.oidc.GetAccessToken(c, controller.oidc.Hash(token))
430430

431431
if err != nil {
432-
if err == service.ErrTokenNotFound {
432+
if errors.Is(err, service.ErrTokenNotFound) {
433433
tlog.App.Warn().Msg("OIDC userinfo accessed with invalid token")
434434
c.JSON(401, gin.H{
435435
"error": "invalid_grant",

internal/service/oidc_service.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -564,7 +564,7 @@ func (service *OIDCService) RefreshAccessToken(c *gin.Context, refreshToken stri
564564
entry, err := service.queries.GetOidcTokenByRefreshToken(c, service.Hash(refreshToken))
565565

566566
if err != nil {
567-
if err == sql.ErrNoRows {
567+
if errors.Is(err, sql.ErrNoRows) {
568568
return TokenResponse{}, ErrTokenNotFound
569569
}
570570
return TokenResponse{}, err
@@ -643,7 +643,7 @@ func (service *OIDCService) GetAccessToken(c *gin.Context, tokenHash string) (re
643643
entry, err := service.queries.GetOidcToken(c, tokenHash)
644644

645645
if err != nil {
646-
if err == sql.ErrNoRows {
646+
if errors.Is(err, sql.ErrNoRows) {
647647
return repository.OidcToken{}, ErrTokenNotFound
648648
}
649649
return repository.OidcToken{}, err
@@ -784,7 +784,7 @@ func (service *OIDCService) Cleanup() {
784784
token, err := service.queries.GetOidcTokenBySub(ctx, expiredCode.Sub)
785785

786786
if err != nil {
787-
if err == sql.ErrNoRows {
787+
if errors.Is(err, sql.ErrNoRows) {
788788
continue
789789
}
790790
tlog.App.Warn().Err(err).Msg("Failed to get OIDC token by sub")

0 commit comments

Comments
 (0)