ldap: Use early-return pattern

plaes · plaes · commit e5694cd2df92 · 2025-12-26T20:10:20.000+02:00
diff --git a/internal/service/ldap_service.go b/internal/service/ldap_service.go
@@ -143,9 +143,8 @@ func (ldap *LdapService) BindService(rebind bool) error {
 
 	if ldap.cert != nil {
 		return ldap.conn.ExternalBind()
-	} else {
-		return ldap.conn.Bind(ldap.config.BindDN, ldap.config.BindPassword)
 	}
+	return ldap.conn.Bind(ldap.config.BindDN, ldap.config.BindPassword)
 }
 
 func (ldap *LdapService) Bind(userDN string, password string) error {

Original file line number	Diff line number	Diff line change
`@@ -143,9 +143,8 @@ func (ldap *LdapService) BindService(rebind bool) error {`
`143`	`143`
`144`	`144`	`if ldap.cert != nil {`
`145`	`145`	`return ldap.conn.ExternalBind()`
`146`		`- } else {`
`147`		`- return ldap.conn.Bind(ldap.config.BindDN, ldap.config.BindPassword)`
`148`	`146`	`}`
	`147`	`+ return ldap.conn.Bind(ldap.config.BindDN, ldap.config.BindPassword)`
`149`	`148`	`}`
`150`	`149`
`151`	`150`	`func (ldap *LdapService) Bind(userDN string, password string) error {`