refactor: categorize leftover config options#682
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughRefactors configuration names from negation-based to affirmation-based, nests flat config fields into composite types (Database, Analytics, Resources), and updates backend controllers, bootstrap, and frontend schema/components to use the new fields and semantics. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
internal/controller/resources_controller.go (1)
20-27: Consider guarding file server initialization when resources are disabled.The
fileServeris initialized unconditionally even whenconfig.Pathis empty orconfig.Enabledis false. While the handler correctly guards against serving in these cases, creating the file server is unnecessary overhead.♻️ Optional: Guard fileServer initialization
func NewResourcesController(config ResourcesControllerConfig, router *gin.RouterGroup) *ResourcesController { - fileServer := http.StripPrefix("/resources", http.FileServer(http.Dir(config.Path))) + var fileServer http.Handler + if config.Enabled && config.Path != "" { + fileServer = http.StripPrefix("/resources", http.FileServer(http.Dir(config.Path))) + } return &ResourcesController{ config: config, router: router, fileServer: fileServer, } }Note: If you apply this, also add a nil check in
resourcesHandlerbefore callingfileServer.ServeHTTP.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@internal/controller/resources_controller.go` around lines 20 - 27, NewResourcesController currently always creates fileServer even when resources are disabled or Path is empty; update NewResourcesController so it only sets fileServer when config.Enabled is true and config.Path is non-empty (e.g., leave fileServer nil otherwise), and then add a nil check in resourcesHandler before calling fileServer.ServeHTTP to avoid dereferencing a nil pointer when resources are disabled.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@internal/controller/resources_controller.go`:
- Around line 20-27: NewResourcesController currently always creates fileServer
even when resources are disabled or Path is empty; update NewResourcesController
so it only sets fileServer when config.Enabled is true and config.Path is
non-empty (e.g., leave fileServer nil otherwise), and then add a nil check in
resourcesHandler before calling fileServer.ServeHTTP to avoid dereferencing a
nil pointer when resources are disabled.
ℹ️ Review info
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (11)
.env.examplefrontend/src/components/layout/layout.tsxfrontend/src/pages/continue-page.tsxfrontend/src/schemas/app-context-schema.tsinternal/bootstrap/app_bootstrap.gointernal/bootstrap/router_bootstrap.gointernal/config/config.gointernal/controller/context_controller.gointernal/controller/context_controller_test.gointernal/controller/resources_controller.gointernal/controller/resources_controller_test.go
Rycochet
reviewed
Mar 2, 2026
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #682 +/- ##
==========================================
- Coverage 15.39% 15.31% -0.09%
==========================================
Files 50 50
Lines 3643 3663 +20
==========================================
Hits 561 561
- Misses 3025 3045 +20
Partials 57 57 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Rycochet
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Chores
Bug Fixes