fix(security): fix requests, pygments; risk-accept langchain-core (ENG-13418)#23
Conversation
…G-13418) - requests 2.32.5 → 2.33.1 (GHSA-gc5v-m9x4-r6x2, MEDIUM) - pygments 2.19.2 → 2.20.0 (GHSA-5239-wwwm-4pmq, LOW) - langchain-core CVE-2026-34070 (GHSA-qh6h-p6c9-ff54, HIGH): risk-accepted in osv-scanner.toml — fix requires 0.3.x→1.2.22 major bump, blocked by langchain-community 0.3.x constraining langchain-core<1.0.0 - remove stale GHSA-5239-wwwm-4pmq ignore (fix now available in pygments 2.20.0)
📝 WalkthroughWalkthroughThe pull request updates dependency declarations and security vulnerability configurations. In 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@osv-scanner.toml`:
- Line 8: Update the ignoreUntil TOML entry to a later date (e.g., add several
months) to extend the mitigation window by changing the ignoreUntil value;
additionally, add notes in the repository (e.g., SECURITY.md or a new
docs/mitigation-plan.md) documenting a concrete mitigation plan with milestones
for upgrading langchain-core and langchain-community, and add an interim
monitoring step (e.g., a CI check or alert) that scans for accidental usage of
the vulnerable APIs before the new deadline; reference the existing ignoreUntil
key and the affected packages langchain-core and langchain-community when making
the changes.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 9bffd7b6-254c-41d4-b6d1-98a34164a4ec
⛔ Files ignored due to path filters (1)
langchain/poetry.lockis excluded by!**/*.lock
📒 Files selected for processing (2)
langchain/pyproject.tomlosv-scanner.toml
|
@hongjingzhou — SPOC review request. Reviewer assignment API returned empty (team-access-only repo). Please review and approve when ready. |
Vulnerability Fixes
langchain-core risk acceptance rationale
The fix for GHSA-qh6h-p6c9-ff54 requires
langchain-core >= 1.2.22, a major version upgrade from our current^0.3.15constraint. This upgrade is blocked becauselangchain-community 0.3.x(also a direct dependency) hard-constrainslangchain-core<1.0.0. The stable 1.x line forlangchain-communityis not yet available (only1.0.0a1alpha exists).Mitigation tracked in
osv-scanner.tomluntil 2026-04-27 (SLA deadline). Theload_prompt/load_prompt_from_configlegacy APIs flagged by this CVE are not used in this integration package.Also removes the stale
GHSA-5239-wwwm-4pmqignore — pygments 2.20.0 ships the fix.Closes Dependabot alerts #38 (requests), #40 (Pygments).
Linear: ENG-13418
Changelog impact summary