fix(security): bump python-dotenv 1.2.1->1.2.2, suppress langchain-text-splitters SSRF (ENG-14769/14677)#28
Conversation
…xt-splitters SSRF (ENG-14769/14677) - python-dotenv >=1.2.2 floor pin (CVE-2026-28684 — symlink file overwrite) - osv-scanner.toml: suppress GHSA-fv5p-p927-qmxr (langchain-text-splitters SSRF; fix requires 1.1.2 which needs langchain-core>=1.2.31, incompatible with langchain-community 0.3.x ecosystem) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
📝 WalkthroughWalkthroughThe pull request adds a new dependency and manages a security consideration. The 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
osv-scanner.toml (1)
3-3: Consider the 3-month suppression window for ongoing risk management.The
ignoreUntildate of 2026-07-24 provides a 3-month window to either migrate to compatible versions or confirm continued risk acceptance. Ensure tracking mechanisms are in place to revisit this decision before expiration.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@osv-scanner.toml` at line 3, The PR sets ignoreUntil = "2026-07-24T00:00:00Z" which creates a 3-month suppression window; update tracking and reminder behavior to ensure this suppression is revisited before expiry by adding or wiring a follow-up process: ensure the configuration key "ignoreUntil" is retained, add/update whatever scheduler or issue-tracking hook that monitors suppression expirations to create a ticket or send an alert ~1–2 weeks before the ignoreUntil date, and document the rationale and owner for this suppression in the surrounding configuration or comments so the team knows who is responsible for migration or risk acceptance decisions.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@osv-scanner.toml`:
- Line 3: The PR sets ignoreUntil = "2026-07-24T00:00:00Z" which creates a
3-month suppression window; update tracking and reminder behavior to ensure this
suppression is revisited before expiry by adding or wiring a follow-up process:
ensure the configuration key "ignoreUntil" is retained, add/update whatever
scheduler or issue-tracking hook that monitors suppression expirations to create
a ticket or send an alert ~1–2 weeks before the ignoreUntil date, and document
the rationale and owner for this suppression in the surrounding configuration or
comments so the team knows who is responsible for migration or risk acceptance
decisions.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 21ccbc63-0673-4535-b81a-10edac69b004
⛔ Files ignored due to path filters (1)
langchain/poetry.lockis excluded by!**/*.lock
📒 Files selected for processing (2)
langchain/pyproject.tomlosv-scanner.toml
Vulnerability Fix
Linear: https://linear.app/tinyfish/issue/ENG-14769 | https://linear.app/tinyfish/issue/ENG-14677
Summary
python-dotenv = ">=1.2.2"floor pin tolangchain/pyproject.toml— fixes CVE-2026-28684 (symlink-following file overwrite inset_key()/unset_key()).langchain-text-splitters>=1.1.2which requireslangchain-core>=1.2.31— breaking major change incompatible withlangchain-community 0.3.x.HTMLHeaderTextSplitter.split_text_from_url()is not called by this integration package.Changelog impact summary
All changes are limited to manifest/lock file version bumps and osv-scanner.toml suppression entries — no functional source code changes.