Linux: Fix: connectHandler after adv.Start#369
Merged
Conversation
In Linux the Adapter.connectHandler is never called after Advertisement.Start. This fix preserves the existing interfaces and adds D-Bus signals to handle connect/disconnect events once the Peripheral is advertising. - Fix Linux Advertise.Start to call the connectHandler, if set - Update inline documentation for Adapter.SetConnectHandler - Update README usage example Signed-off-by: Nick Ross <nick.ross@intel.com>
deadprogram
reviewed
Jun 6, 2025
deadprogram
reviewed
Jun 6, 2025
Signed-off-by: Nick Ross <nick.ross@intel.com>
deadprogram
reviewed
Jun 10, 2025
deadprogram
reviewed
Jun 10, 2025
- Add alias update on adveristing - Extend property handling for signals - Correct README example Signed-off-by: Nick Ross <nick.ross@intel.com>
deadprogram
reviewed
Jun 11, 2025
Signed-off-by: Nick Ross <nick.ross@intel.com>
Signed-off-by: Nick Ross <nick.ross@intel.com>
Member
|
Thanks for working on this @nckrss now squash/merging. |
This was referenced Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Linux the Adapter.connectHandler is never called after Advertisement.Start.
This fix preserves the existing interfaces and adds D-Bus signals to handle connect/disconnect events once the Peripheral is advertising.
Potentially fixes #360 and #354.