Skip to content

fix(darwin): WriteWithoutResponse checks CanSendWriteWithoutResponse before request #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deadprogram merged 7 commits into from
Mar 24, 2026
Merged

fix(darwin): WriteWithoutResponse checks CanSendWriteWithoutResponse before request #386

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fe363b9
feat(gattc): add CanSendWriteWithoutResponse for darwin
acouvreur Oct 4, 2025
6b21611
fix doc
acouvreur Oct 4, 2025
319250f
WriteWithoutResponse checks if it can send write without response req…
acouvreur Oct 21, 2025
0e87cf5
remove mutex
acouvreur Oct 23, 2025
281cb3f
remove unused named return params
acouvreur Oct 23, 2025
c963fbd
pr review
acouvreur Mar 24, 2026
b7ad315
update code comment:
acouvreur Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions gattc_darwin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ import (
"github.com/tinygo-org/cbgo"
)

var (
errCannotSendWriteWithoutResponse = errors.New("bluetooth: cannot send write without response (buffer full)")
)

// DiscoverServices starts a service discovery procedure. Pass a list of service
// UUIDs you are interested in to this function. Either a slice of all services
// is returned (of the same length as the requested UUIDs and in the same
Expand Down Expand Up @@ -199,9 +203,13 @@ func (c DeviceCharacteristic) Write(p []byte) (n int, err error) {

// WriteWithoutResponse replaces the characteristic value with a new value. The
// call will return before all data has been written. A limited number of such
// writes can be in flight at any given time. This call is also known as a
// "write command" (as opposed to a write request).
func (c DeviceCharacteristic) WriteWithoutResponse(p []byte) (n int, err error) {
// writes can be in flight at any given time.
// If the client is not ready to send write without response requests at this time (e.g. because the internal buffer is full), an error is returned.
func (c DeviceCharacteristic) WriteWithoutResponse(p []byte) (int, error) {
if !c.service.device.prph.CanSendWriteWithoutResponse() {
return 0, errCannotSendWriteWithoutResponse
}

c.service.device.prph.WriteCharacteristic(p, c.characteristic, false)

return len(p), nil
Expand Down
Loading