Add MAC accessor for returning the MAC in the usual format#397
Merged
Conversation
The MAC address in the bluetooth.MAC type is little endian, the reverse of what is commonly used. The usual way a MAC address is printed is big endian. To simplify code, the Address() method will return the address in the usual (big endian) format.
Member
|
I needed exactly this, thanks @aykevl Naming is fine for me, not going to bikeshed it. Now merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MAC address in the bluetooth.MAC type is little endian, the reverse of what is commonly used. The usual way a MAC address is printed is big endian. To simplify code, the Address() method will return the address in the usual (big endian) format.
Feel free to bikeshed on the name, I don't know whether
Addressreally captures it well. Also, perhaps we should make the underlying data type private at some point? Though that may break existing users.