Skip to content

feat: add PHY type#424

Merged
deadprogram merged 2 commits intotinygo-org:devfrom
acouvreur:add-phy
Mar 19, 2026
Merged

feat: add PHY type#424
deadprogram merged 2 commits intotinygo-org:devfrom
acouvreur:add-phy

Conversation

@acouvreur
Copy link
Copy Markdown
Contributor

Platform will now be able to implement Device.GetPHY() by returning this PHY type extracted from the platform specific types.

I will follow up with a implementation for Windows to be able to read the current device Phy.

Few notes:

  • This could definitely be in gap.go
  • I could add an unknown phy enum, but the default is PHY1M for all BLE devices

Platform will now be able to implement Device.GetPHY() by returning this PHY type extracted from the platform specific types.
@deadprogram
Copy link
Copy Markdown
Member

This could definitely be in gap.go

That seems like the most logical place to add it.

I could add an unknown phy enum, but the default is PHY1M for all BLE devices

Valid point.

@acouvreur
Copy link
Copy Markdown
Contributor Author

@deadprogram I have moved the PHY definitions to gap.go

@deadprogram
Copy link
Copy Markdown
Member

Thanks for the addition @acouvreur now squash/merging.

@deadprogram deadprogram merged commit 80414ef into tinygo-org:dev Mar 19, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants