fix(darwin): Device.DiscoverServices() filters discovered services#428
Merged
deadprogram merged 2 commits intotinygo-org:devfrom Mar 24, 2026
Merged
Conversation
Currently, even if you pass a slice of services to discover. CoreBluetooth still discover ALL services. As per the CoreBluetooth documentation: "If the servicesUUIDs parameter is nil, this method returns all of the peripheral’s available services. This is much slower than providing an array of service UUIDs to search for."
…acteristics Currently, even if you pass a slice of characteristics to discover. CoreBluetooth still discover ALL characteristics. As per the CoreBluetooth documentation: " If the characteristicUUIDs parameter is nil, this method returns all of the service’s characteristics. This is much slower than providing an array of characteristic UUIDs to search for."
Member
|
Thank you very much for the fix here @acouvreur now squash/merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, even if you pass a slice of services to discover. CoreBluetooth still discover ALL services which is slow.
As per the CoreBluetooth documentation:
Edit: also added the same fix for DiscoverCharacteristics