Skip to content

fix(darwin): Device.DiscoverServices() filters discovered services #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deadprogram merged 2 commits into from
Mar 24, 2026
Merged

fix(darwin): Device.DiscoverServices() filters discovered services #428

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41908f4
fix(darwin): Device.DiscoverServices() filters discovered services
acouvreur Mar 21, 2026
088ca97
fix(darwin): Device.DiscoverCharacteristics() filters discovered char…
acouvreur Mar 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions gattc_darwin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,16 @@ import (
// Passing a nil slice of UUIDs will return a complete list of
// services.
func (d Device) DiscoverServices(uuids []UUID) ([]DeviceService, error) {
d.prph.DiscoverServices([]cbgo.UUID{})
cbuuids := make([]cbgo.UUID, len(uuids))
for i, u := range uuids {
cbuuid, err := cbgo.ParseUUID(u.String())
if err != nil {
return nil, err
}
cbuuids[i] = cbuuid
}

d.prph.DiscoverServices(cbuuids)

// clear cache of services
d.services = make(map[UUID]DeviceService)
Expand Down Expand Up @@ -106,7 +115,14 @@ func (s DeviceService) UUID() UUID {
// Passing a nil slice of UUIDs will return a complete list of
// characteristics.
func (s DeviceService) DiscoverCharacteristics(uuids []UUID) ([]DeviceCharacteristic, error) {
cbuuids := []cbgo.UUID{}
cbuuids := make([]cbgo.UUID, len(uuids))
for i, u := range uuids {
cbuuid, err := cbgo.ParseUUID(u.String())
if err != nil {
return nil, err
}
cbuuids[i] = cbuuid
}

s.device.prph.DiscoverCharacteristics(cbuuids, s.service)

Expand Down
Loading