fix(windows): close leaked resources#453
Open
acouvreur wants to merge 1 commit into
Open
Conversation
A lot of resources were not closed. Closes #451
Member
Author
|
@jagobagascon any input here on those missing Does it seem legit to you ? |
This was referenced May 20, 2026
There was a problem hiding this comment.
Pull request overview
This PR targets Windows-specific memory/resource leaks in the BLE central implementation, addressing issue #451 by ensuring WinRT objects (async operations, result objects, buffers, vector views, readers) are properly released after use.
Changes:
- Add
Release()defers for WinRT async operations and result/vector objects in GATT service/characteristic discovery. - Release buffers/readers/results used in GATT characteristic write/read and notification handling.
- Release WinRT objects created during scan result parsing and during
Adapter.Connect(async ops and device ID).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| gattc_windows.go | Adds Release() calls for WinRT async ops/results/buffers used by GATT service/characteristic discovery, read/write, and notifications. |
| gap_windows.go | Adds Release() calls for WinRT advertisement vectors/elements/buffers during scan parsing and releases WinRT async ops used during connect/session creation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
242
to
256
| for i := uint32(0); i < size; i++ { | ||
| element, _ := vector.GetAt(i) | ||
| element, _ := manDataVector.GetAt(i) | ||
| manData := (*advertisement.BluetoothLEManufacturerData)(element) | ||
|
|
||
| companyID, _ := manData.GetCompanyId() | ||
| buffer, _ := manData.GetData() | ||
| manufacturerData = append(manufacturerData, ManufacturerDataElement{ | ||
| CompanyID: companyID, | ||
| Data: bufferToSlice(buffer), | ||
| }) | ||
| if buffer != nil { | ||
| manufacturerData = append(manufacturerData, ManufacturerDataElement{ | ||
| CompanyID: companyID, | ||
| Data: bufferToSlice(buffer), | ||
| }) | ||
| buffer.Release() | ||
| } | ||
| manData.Release() | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lot of resources were not closed. Closes #451