More Go idiomatic API

Author: FilipVranesevic

sx126x/radiocontrol_wio_sx1262.go

@@ -11,7 +11,7 @@ import (
 // if SetDio2AsRfSwitchCtrl is set to true (use machine.NoPin instead).
 // Additionally, the board requires following settings on initalization:
 /*
- 	radio.SetDio3AsTcxoCtrl(sx126x.SX126X_DIO3_OUTPUT_1_8, 500)
+	radio.SetDio3AsTcxoCtrl(sx126x.SX126X_DIO3_OUTPUT_1_8, 5*time.Microsecond)
  	radio.SetRegulatorMode(sx126x.SX126X_REGULATOR_DC_DC)
 	radio.SetDeviceType(sx126x.DEVICE_TYPE_SX1262)
 */

sx126x/registers.go

@@ -181,16 +181,6 @@ const (
 	SX126X_DIO2_AS_IRQ       = 0x00 //  7     0     DIO2 configuration: IRQ
 	SX126X_DIO2_AS_RF_SWITCH = 0x01 //  7     0                         RF switch control
 
-	//SX126X_CMD_SET_DIO3_AS_TCXO_CTRL
-	SX126X_DIO3_OUTPUT_1_6 = 0x00 //  7     0     DIO3 voltage output for TCXO: 1.6 V
-	SX126X_DIO3_OUTPUT_1_7 = 0x01 //  7     0                                   1.7 V
-	SX126X_DIO3_OUTPUT_1_8 = 0x02 //  7     0                                   1.8 V
-	SX126X_DIO3_OUTPUT_2_2 = 0x03 //  7     0                                   2.2 V
-	SX126X_DIO3_OUTPUT_2_4 = 0x04 //  7     0                                   2.4 V
-	SX126X_DIO3_OUTPUT_2_7 = 0x05 //  7     0                                   2.7 V
-	SX126X_DIO3_OUTPUT_3_0 = 0x06 //  7     0                                   3.0 V
-	SX126X_DIO3_OUTPUT_3_3 = 0x07 //  7     0                                   3.3 V
-
 	//SX126X_CMD_SET_PACKET_TYPE
 	SX126X_PACKET_TYPE_GFSK = 0x00 //  7     0     packet type: GFSK
 	SX126X_PACKET_TYPE_LORA = 0x01 //  7     0                  LoRa
@@ -312,3 +302,17 @@ const (
 	SX126X_LORA_MAC_PUBLIC_SYNCWORD  = 0x3444
 	SX126X_LORA_MAC_PRIVATE_SYNCWORD = 0x1424
 )
+
+type Dio3OutputVoltage uint8
+
+const (
+	//SX126X_CMD_SET_DIO3_AS_TCXO_CTRL
+	SX126X_DIO3_OUTPUT_1_6 Dio3OutputVoltage = 0x00 //  7     0     DIO3 voltage output for TCXO: 1.6 V
+	SX126X_DIO3_OUTPUT_1_7 Dio3OutputVoltage = 0x01 //  7     0                                   1.7 V
+	SX126X_DIO3_OUTPUT_1_8 Dio3OutputVoltage = 0x02 //  7     0                                   1.8 V
+	SX126X_DIO3_OUTPUT_2_2 Dio3OutputVoltage = 0x03 //  7     0                                   2.2 V
+	SX126X_DIO3_OUTPUT_2_4 Dio3OutputVoltage = 0x04 //  7     0                                   2.4 V
+	SX126X_DIO3_OUTPUT_2_7 Dio3OutputVoltage = 0x05 //  7     0                                   2.7 V
+	SX126X_DIO3_OUTPUT_3_0 Dio3OutputVoltage = 0x06 //  7     0                                   3.0 V
+	SX126X_DIO3_OUTPUT_3_3 Dio3OutputVoltage = 0x07 //  7     0                                   3.3 V
+)

sx126x/sx126x.go

@@ -315,17 +315,20 @@ func (d *Device) SetDioIrqParams(irqMask, dio1Mask, dio2Mask, dio3Mask uint16) {
 // the internal state machine (DIO2 = 0 in SLEEP, STDBY_RX, STDBY_XOSC, FS and RX modes,
 // DIO2 = 1 in TX mode). Otherwise DIO2 is free to be used as an IRQ.
 func (d *Device) SetDio2AsRfSwitchCtrl(enable bool) {
-	var p [1]uint8
+	p := [1]uint8{SX126X_DIO2_AS_IRQ}
 	if enable {
-		p[0] = 0x01
+		p[0] = SX126X_DIO2_AS_RF_SWITCH
 	}
 	d.ExecSetCommand(SX126X_CMD_SET_DIO2_AS_RF_SWITCH_CTRL, p[:])
 }
 
 // SetDio3AsTcxoCtrl configures the DIO3 as an external TCXO voltage reference.
-func (d *Device) SetDio3AsTcxoCtrl(voltage uint8, timeout uint32) {
+// voltage: output voltage on DIO3 pin
+// delay: time for the TCXO to stabilize
+func (d *Device) SetDio3AsTcxoCtrl(voltage Dio3OutputVoltage, delay time.Duration) {
+	timeout := delay / (15625 * time.Nanosecond)
 	var p [5]uint8
-	p[0] = voltage
+	p[0] = uint8(voltage)
 	p[1] = uint8((timeout >> 24) & 0xFF)
 	p[2] = uint8((timeout >> 16) & 0xFF)
 	p[3] = uint8((timeout >> 8) & 0xFF)