Conversation
3e7d622 to
da8f36a
Compare
c1be1ad to
f6019de
Compare
a80f02b to
b386f8c
Compare
|
Anything else needed on this PR @HattoriHanzo031 ? Ignore my IRL questions about the |
I just did one last minute change to use new |
| type Device struct { | ||
| spi drivers.SPI // SPI bus for module communication | ||
| rstPin machine.Pin // GPIO for reset pin | ||
| rstPin pin.Output // GPIO for reset pin |
|
I'll volunteer to test this as I'm working with this hardware right now, but the PR looks good. |
@Escalion Thank you, this would be very helpful. Please report any bugs or improvements that could be implemented. P.S. what is the exact hardware you are using (MCU/module combination)? |
|
I've got a couple of the sx1262 boards coming in (LILYGO T3S3) that I could use to test. I saw another issue related to this driver in searching (#703) and brought up there that it would probably be nice (although a bit breaking) if the base As well as the base driver doesn't expose DIO pins 2 and 3 (likely because whatever module was being used only has DIO1 connected) and the specific modules could simply use NoPins to reflect that they don't have that connection. |
No description provided.