Skip to content

Commit fbc528d

Browse files
jgangemiclaude
andcommitted
fix: resolve golangci-lint warnings
- wrap flasher.Close() error in defer closure - handle error return from SetReadTimeout() - use explicit _ assignment for unused error - remove redundant XOR in checksum test Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 67380ee commit fbc528d

File tree

4 files changed

+10
-4
lines changed

4 files changed

+10
-4
lines changed

main.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,11 @@ func main() {
112112
if err != nil {
113113
log.Fatalf("Failed to connect: %v", err)
114114
}
115-
defer flasher.Close()
115+
defer func() {
116+
if err := flasher.Close(); err != nil {
117+
log.Printf("Warning: failed to close flasher: %v", err)
118+
}
119+
}()
116120

117121
fmt.Printf("Chip: %s\n", flasher.ChipName())
118122

pkg/espflasher/flasher.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -963,5 +963,5 @@ type StdoutLogger struct {
963963

964964
// Logf implements the Logger interface.
965965
func (l *StdoutLogger) Logf(format string, args ...interface{}) {
966-
fmt.Fprintf(l.W, format+"\n", args...)
966+
_, _ = fmt.Fprintf(l.W, format+"\n", args...)
967967
}

pkg/espflasher/protocol_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ func TestChecksum(t *testing.T) {
2222
{
2323
name: "single byte zero",
2424
data: []byte{0x00},
25-
expected: checksumMagic ^ 0x00,
25+
expected: checksumMagic,
2626
},
2727
{
2828
name: "single byte 0xFF",

pkg/espflasher/slip.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,9 @@ func (r *slipReader) ReadFrame(timeout time.Duration) ([]byte, error) {
9393
}
9494

9595
readTimeout := min(remaining, 100*time.Millisecond)
96-
r.port.SetReadTimeout(readTimeout)
96+
if err := r.port.SetReadTimeout(readTimeout); err != nil {
97+
return nil, fmt.Errorf("failed to set read timeout: %w", err)
98+
}
9799

98100
n, err := r.port.Read(buf)
99101
if err != nil && err != io.EOF {

0 commit comments

Comments
 (0)