Skip to content

runtime: handle GODEBUG on wasip2#5312

Merged
deadprogram merged 4 commits intotinygo-org:devfrom
jakebailey:wasip2-godebug
Apr 18, 2026
Merged

runtime: handle GODEBUG on wasip2#5312
deadprogram merged 4 commits intotinygo-org:devfrom
jakebailey:wasip2-godebug

Conversation

@jakebailey
Copy link
Copy Markdown
Member

@jakebailey jakebailey commented Apr 16, 2026

This is the fix for what I mentioned in #5304 (comment), the only reason a couple of URL tests fail in CI.

@deadprogram deadprogram added this to the 0.41.0 milestone Apr 17, 2026
@jakebailey jakebailey marked this pull request as ready for review April 17, 2026 20:10
@jakebailey
Copy link
Copy Markdown
Member Author

Intersting, this totally passed locally for me, yet fails in CI.

@deadprogram
Copy link
Copy Markdown
Member

That looks a lot like some build tag thing @jakebailey

Also, please note merge conflict.

@deadprogram
Copy link
Copy Markdown
Member

I restarted the Windows build cause it looked to have failed for some network dependency download hiccup. Let us see...

@jakebailey
Copy link
Copy Markdown
Member Author

Yeah, there are other platforms that are missing things and that's what breaks. That being said, it doesn't seem to hard to make that work either? See the latest commit (the PR is now mistitled but I can fix that if this seems reasonable).

@jakebailey
Copy link
Copy Markdown
Member Author

So many platforms... 😄

@deadprogram
Copy link
Copy Markdown
Member

@jakebailey
Copy link
Copy Markdown
Member Author

Might be wrong but isn't that unrelated?

@deadprogram
Copy link
Copy Markdown
Member

Might be wrong but isn't that unrelated?

Could be. Rerunning job now just in case while I look at that error.

@deadprogram
Copy link
Copy Markdown
Member

Some kind of race condition? I have not seen it before, but context is somewhat new for us to be testing.

In any case, unless it occurs again, I am not going to concern myself. Hence squash/merging this PR @jakebailey thank you very much!

@deadprogram deadprogram merged commit bcb191c into tinygo-org:dev Apr 18, 2026
25 of 26 checks passed
@jakebailey jakebailey deleted the wasip2-godebug branch April 18, 2026 21:17
@jakebailey
Copy link
Copy Markdown
Member Author

Ah, I didn't get a chance to retitle it to explain the scope. oh well 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants