runtime: handle GODEBUG on wasip2#5312
Conversation
519a814 to
b440359
Compare
|
Intersting, this totally passed locally for me, yet fails in CI. |
|
That looks a lot like some build tag thing @jakebailey Also, please note merge conflict. |
b440359 to
9d4a784
Compare
|
I restarted the Windows build cause it looked to have failed for some network dependency download hiccup. Let us see... |
|
Yeah, there are other platforms that are missing things and that's what breaks. That being said, it doesn't seem to hard to make that work either? See the latest commit (the PR is now mistitled but I can fix that if this seems reasonable). |
|
So many platforms... 😄 |
|
Might be wrong but isn't that unrelated? |
Could be. Rerunning job now just in case while I look at that error. |
|
Some kind of race condition? I have not seen it before, but In any case, unless it occurs again, I am not going to concern myself. Hence squash/merging this PR @jakebailey thank you very much! |
|
Ah, I didn't get a chance to retitle it to explain the scope. oh well 😄 |
This is the fix for what I mentioned in #5304 (comment), the only reason a couple of URL tests fail in CI.