fix interp: swap operands if the pointer operand is second#5314
Closed
hectorchu wants to merge 1 commit intotinygo-org:devfrom
Closed
fix interp: swap operands if the pointer operand is second#5314hectorchu wants to merge 1 commit intotinygo-org:devfrom
hectorchu wants to merge 1 commit intotinygo-org:devfrom
Conversation
Member
|
Thanks for working on this @hectorchu A few comments:
What do you think? |
Author
|
Author
|
Nevermind about checking for xtensa - figured it out. |
Author
|
Hmm weird. I just removed this "workaround" and the build of my module worked. I don't know why but this workaround doesn't seem to be required anymore. I will close this PR until I notice that I need it again. |
Member
|
Also, I think LLVM does this flip already for canonicalization. Also, doing this for |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the xtensa backend, it may have the second operand as the pointer and the first as the integer. Don't fail - swap them before the regular code path.