Fix review follow-ups from key and CLI PRs#248
Conversation
|
@naturedesk is attempting to deploy a commit to the Vezures Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe Python SDK now uses regex-based base64-like public-key detection and tests legacy routing for non-canonical identifiers. The TypeScript PTY harness synchronously loads ChangesPython key routing
TypeScript PTY loading
Estimated code review effort: 2 (Simple) | ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
import("node-pty")in the CLI harness with the existingcreateRequireloader, preserving lazy loading while following SDK import rulesVerification
uv run --with pytest --with pytest-asyncio --with-editable . pytest -o addopts='' tests/test_api_namespaces.pysdk/typescript/node_modules/.bin/vitest run sdk/typescript/tests/cli.test.tssdk/typescript/node_modules/.bin/tsc --noEmit --project sdk/typescript/tsconfig.json --pretty falseRefs #213
Refs #216
Refs #217
Follow-up to #244 and #245.
Summary by CodeRabbit