fix: utf8 on windows#35
Merged
Merged
Conversation
This reverts commit 91cb4a9.
| import {spawn} from 'node:child_process'; | ||
|
|
||
| const TIMEOUT = 2000; | ||
| const TIMEOUT = 3000; |
Collaborator
Author
There was a problem hiding this comment.
While testing, I found powershell can take some time to init for the first call so I bumped this a bit. Maybe we could bump it to 5s to make sure it always has time to load, in most cases it should not take that much time anyways
43081j
reviewed
May 26, 2026
43081j
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #34. Commands were provided by AI but I adapted and tested the code.
Testing
CI does not fail on windows for utf8 chars, it needs to be checked manually. I checked manually on Windows 11 (no WSL) and it worked