Skip to content

Commit 26d2701

Browse files
committed
DOC-3468: Address remaining PR feedback — id scope, floating sidebar, antora revert
- Revert antora.yml live demo URL from 8-dev to 8 - Scope custom action `id` to menu items only (confirmed from source: addMenuItem only, no addButton) — remove quickbars/toolbar references - Remove dedicated floating sidebar ToggleSidebar section; replace with sidebar-type-agnostic NOTE (TINY-14243 made API identical for both) - Clean up id example to remove misleading quickbars config
1 parent 01b2946 commit 26d2701

4 files changed

Lines changed: 5 additions & 9 deletions

File tree

antora.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ asciidoc:
1010
companyurl: https://www.tiny.cloud
1111
cdnurl: https://cdn.tiny.cloud/1/no-api-key/tinymce/8/tinymce.min.js
1212
tdcdnurl: https://cdn.tiny.cloud/1/_your_api_key_/tinydrive/8/tinydrive.min.js
13-
tinymce_live_demo_url: https://cdn.tiny.cloud/1/qagffr3pkuv17a8on1afax661irst1hbr4e6tbv888sz91jc/tinymce/8-dev/tinymce.min.js
13+
tinymce_live_demo_url: https://cdn.tiny.cloud/1/qagffr3pkuv17a8on1afax661irst1hbr4e6tbv888sz91jc/tinymce/8/tinymce.min.js
1414
tinydrive_live_demo_url: https://cdn.tiny.cloud/1/qagffr3pkuv17a8on1afax661irst1hbr4e6tbv888sz91jc/tinydrive/8/tinydrive.min.js
1515
webcomponent_url: https://cdn.jsdelivr.net/npm/@tinymce/tinymce-webcomponent/dist/tinymce-webcomponent.min.js
1616
jquery_url: https://cdn.jsdelivr.net/npm/@tinymce/tinymce-jquery@2/dist/tinymce-jquery.min.js

modules/ROOT/pages/tinymceai-actions.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ tinymce.init({
8383

8484
[NOTE]
8585
====
86-
AI controls are not added to the xref:quickbars.adoc#quickbars_selection_toolbar[`+quickbars_selection_toolbar+`] automatically; add the desired toolbar button identifiers to that option when they should appear there. Custom actions defined by xref:tinymceai.adoc#tinymceai_quickactions_custom[`+id+`] can also be listed in `+quickbars_selection_toolbar+`.
86+
AI controls are not added to the xref:quickbars.adoc#quickbars_selection_toolbar[`+quickbars_selection_toolbar+`] automatically; add the desired toolbar button identifiers to that option when they should appear there.
8787
8888
For example:
8989

modules/ROOT/partials/commands/tinymceai-cmds.adoc

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,7 @@ tinymce.activeEditor.execCommand('ToggleSidebar', false, 'tinymceai-chat');
1919
tinymce.activeEditor.execCommand('ToggleSidebar', false, 'tinymceai-review');
2020
----
2121

22-
[[tinymceai-floating-sidebar-api]]
23-
=== Floating sidebar and `+ToggleSidebar+`
24-
25-
When xref:tinymceai.adoc#tinymceai_sidebar_type[`tinymceai_sidebar_type`] is `+'floating'+`, the core `+ToggleSidebar+` command, the `+ToggleSidebar+` event, and `+queryCommandValue('ToggleSidebar')+` work the same as for a static sidebar for `+'tinymceai-chat'+` and `+'tinymceai-review'+`.
22+
NOTE: These commands work regardless of xref:tinymceai.adoc#tinymceai_sidebar_type[`tinymceai_sidebar_type`] (`+'static'+` or `+'floating'+`). The `+ToggleSidebar+` event and `+queryCommandValue('ToggleSidebar')+` also behave the same for both sidebar types.
2623

2724
[[tinymceai-plugin-commands]]
2825
=== TinyMCE AI plugin commands

modules/ROOT/partials/configuration/tinymceai_options.adoc

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -440,7 +440,7 @@ Array of custom actions rendered in the Custom submenu within the AI Quick Actio
440440
* `+prompt+`: The prompt sent to the AI
441441
* `+type+`: `+'action'+` or `+'chat'+`
442442
* `+model+`: Required for `+action+` type only
443-
* `+id+` (optional): Stable identifier for the custom action. When set, the same string can be listed in xref:tinymceai.adoc#tinymceai_quickactions_menu[`tinymceai_quickactions_menu`] so the action appears as its own top-level menu item instead of only inside the Custom submenu. The identifier can also be used in xref:quickbars.adoc#quickbars_selection_toolbar[`+quickbars_selection_toolbar+`], the xref:menus-configuration-options.adoc#menu[`+menu+`] option, or any other toolbar or menu configuration that accepts control identifiers.
443+
* `+id+` (optional): Stable identifier for the custom action. When set, the same string can be listed in xref:tinymceai.adoc#tinymceai_quickactions_menu[`tinymceai_quickactions_menu`] so the action appears as its own top-level menu item instead of only inside the Custom submenu. The identifier can also be used in the xref:menus-configuration-options.adoc#menu[`+menu+`] option or any other menu configuration that accepts menu item identifiers.
444444

445445
*Type:* `+Array+` of `+Object+`
446446

@@ -480,9 +480,8 @@ tinymce.init({
480480
----
481481
tinymce.init({
482482
selector: 'textarea',
483-
plugins: 'quickbars tinymceai',
483+
plugins: 'tinymceai',
484484
toolbar: 'tinymceai-chat tinymceai-quickactions tinymceai-review',
485-
quickbars_selection_toolbar: 'tinymceai-quickactions | bold italic',
486485
tinymceai_quickactions_menu: [
487486
'ai-quickactions-chat-prompts',
488487
'ai-quote',

0 commit comments

Comments
 (0)