Skip to content

DOC-3199: Fixed Image Optimizer filters in the demo.#3686

Merged
ShiridiGandham merged 2 commits into
tinymce/7from
hotfix/7/DOC-3199
Apr 15, 2025
Merged

DOC-3199: Fixed Image Optimizer filters in the demo.#3686
ShiridiGandham merged 2 commits into
tinymce/7from
hotfix/7/DOC-3199

Conversation

@abhinavgandham
Copy link
Copy Markdown

@abhinavgandham abhinavgandham commented Apr 14, 2025

Ticket: DOC-3199

Site: Updated demo
Site: {name: 'none'} explanation - The explanation is in the Important section.

Changes:

  • Updated the demo to have 9 filter options including the {name: 'none'} option.
  • Added an explanation about {name: 'none'} option and what happens if this option is not set during setup.

Pre-checks:

  • Branch prefixed with feature/<version>/, hotfix/<version>/, staging/<version>/, or release/<version>/.

Review:

  • Documentation Team Lead has reviewed

Copy link
Copy Markdown
Contributor

@ShiridiGandham ShiridiGandham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown

@soritaheng soritaheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'none' filter option is working as expected in the demo and the note on the behavior is also clear!

Comment thread modules/ROOT/partials/configuration/uploadcare_filters.adoc Outdated
Copy link
Copy Markdown
Contributor

@ShiridiGandham ShiridiGandham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShiridiGandham ShiridiGandham merged commit cc2220f into tinymce/7 Apr 15, 2025
5 checks passed
@ShiridiGandham ShiridiGandham deleted the hotfix/7/DOC-3199 branch April 15, 2025 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants