Skip to content

TCLOUD-4780: Fixed the credentials used to delete closed PR previews#3920

Merged
tiny-james merged 3 commits into
mainfrom
feature/TCLOUD-4780-fix-aws-credentials
Nov 20, 2025
Merged

TCLOUD-4780: Fixed the credentials used to delete closed PR previews#3920
tiny-james merged 3 commits into
mainfrom
feature/TCLOUD-4780-fix-aws-credentials

Conversation

@tiny-james

@tiny-james tiny-james commented Nov 19, 2025

Copy link
Copy Markdown
Contributor

Changes:

  • Allow previews to be successfully deleted by assuming an IAM role that actually exists...

This problem was identified when the previous PR in this chain was closed and the deletion task failed:
https://github.com/tinymce/tinymce-docs/actions/runs/19491415346

Review:

  • Documentation Team Lead has reviewed

@tiny-james tiny-james requested a review from a team as a code owner November 19, 2025 06:11

@ShiridiGandham ShiridiGandham left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiny-james tiny-james merged commit ece2fa1 into main Nov 20, 2025
5 checks passed
@tiny-james tiny-james deleted the feature/TCLOUD-4780-fix-aws-credentials branch November 20, 2025 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants