Skip to content

TCLOUD-4780: Fixed the credentials used to delete closed PR previews #3920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tiny-james merged 3 commits into from
Nov 20, 2025
Merged

TCLOUD-4780: Fixed the credentials used to delete closed PR previews #3920

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0af244f
TCLOUD-4780: Fixed the credentials used to delete closed PR previews
tiny-james Nov 19, 2025
90a3912
TCLOUD-4780: Added missing `--recursive` flag
tiny-james Nov 19, 2025
93bbaa6
TCLOUD-4780: Updated the pull request template with the preview URL
tiny-james Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Ticket: DOC-<num>

Site: [Staging branch](http://docs-<hotfix|feature>-<version>-doc-<num>.staging.tiny.cloud/docs/tinymce/<version>/)
Site: [Staging branch](https://pr-<PR#>.tinymce-docs.iad.staging.tiny.cloud/docs/tinymce/<version>/)

Changes:
* <placeholder-text>
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/preview_delete.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,10 @@ jobs:
- name: configure aws credentials
uses: aws-actions/configure-aws-credentials@v5.0.0
with:
role-to-assume: arn:aws:iam::327995277200:role/staging-docs-preview-update
role-session-name: docs-preview-delete
role-to-assume: arn:aws:iam::327995277200:role/staging-tinymce-docs-update
role-session-name: tinymce-docs-delete
aws-region: us-east-2

- name: Remove website preview from S3
run: |
aws s3 rm s3://tiny-cloud-antora-docs-preview/${PR}
aws s3 rm --recursive s3://tiny-cloud-antora-docs-preview/${PR}
Loading