-
Notifications
You must be signed in to change notification settings - Fork 8
TINY-11909: Add support for readonly mode #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
222d608
TINY-11909: first implementation
lorenzo-pomili f2833fc
TINY-11909: add changelog entries
lorenzo-pomili f004f6f
TINY-11909: split disable and readonly stories
lorenzo-pomili 155e3ff
TINY-11909: fix check
lorenzo-pomili 866400a
TINY-11909: improvement
lorenzo-pomili f7ddab9
TINY-11909: add check for isDisabledOptionSupported
lorenzo-pomili 3fc5cbf
TINY-11909: improvemente
lorenzo-pomili 1b2dcc2
TINY-11909: refactor
lorenzo-pomili b392a65
TINY-11909: fix
lorenzo-pomili 45318dd
TINY-11909: refactor
lorenzo-pomili 93a32fa
TINY-11909: update version
lorenzo-pomili c1cfc7b
Update src/main/component/Editor.svelte
tiny-ben-tran File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this check needs to be different after talking to @michalnieruchalski-tiugo since we want to feed readonly or disabled in at init time as well and then we don't have the editor instance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If they use disabled=true on a old editor version then it wouldn't be disabled since that option didn't exist prior to 7.6.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@spocke, @michalnieruchalski-tiugo I fixed it, with a check in the setup, let me know what do you think about it