Merge pull request lightspeed-core#1672 from asimurka/replace_success_field

LCORE-2034: Replace deprecated success field

Author: tisnik

docs/openapi.json

@@ -16485,21 +16485,13 @@
                         "title": "Response",
                         "description": "Human-readable outcome of the delete operation.",
                         "readOnly": true
-                    },
-                    "success": {
-                        "type": "boolean",
-                        "title": "Success",
-                        "description": "Successful response flag.",
-                        "deprecated": true,
-                        "readOnly": true
                     }
                 },
                 "type": "object",
                 "required": [
                     "deleted",
                     "prompt_id",
-                    "response",
-                    "success"
+                    "response"
                 ],
                 "title": "PromptDeleteResponse",
                 "description": "Result of deleting a stored prompt (always HTTP 200, like conversations v2).",
@@ -19990,21 +19982,13 @@
                         "title": "Response",
                         "description": "Human-readable outcome of the delete operation.",
                         "readOnly": true
-                    },
-                    "success": {
-                        "type": "boolean",
-                        "title": "Success",
-                        "description": "Successful response flag.",
-                        "deprecated": true,
-                        "readOnly": true
                     }
                 },
                 "type": "object",
                 "required": [
                     "deleted",
                     "vector_store_id",
-                    "response",
-                    "success"
+                    "response"
                 ],
                 "title": "VectorStoreDeleteResponse",
                 "description": "Result of deleting a vector store (always HTTP 200).",
@@ -20134,21 +20118,13 @@
                         "title": "Response",
                         "description": "Human-readable outcome of the delete operation.",
                         "readOnly": true
-                    },
-                    "success": {
-                        "type": "boolean",
-                        "title": "Success",
-                        "description": "Successful response flag.",
-                        "deprecated": true,
-                        "readOnly": true
                     }
                 },
                 "type": "object",
                 "required": [
                     "deleted",
                     "file_id",
-                    "response",
-                    "success"
+                    "response"
                 ],
                 "title": "VectorStoreFileDeleteResponse",
                 "description": "Result of deleting a file from a vector store (always HTTP 200).",

src/models/responses.py

@@ -79,12 +79,6 @@ def response(self) -> str:
             else f"{self.resource_name} not found"
         )
 
-    @computed_field(json_schema_extra={"deprecated": True})
-    def success(self) -> bool:
-        """Successful response flag."""
-        logger.warning("DEPRECATED: Will be removed in a future release.")
-        return True
-
     @classmethod
     def openapi_response(cls) -> dict[str, Any]:
         """Build FastAPI/OpenAPI metadata with named application/json examples.
@@ -1157,6 +1151,12 @@ class ConversationDeleteResponse(AbstractDeleteResponse):
         examples=["123e4567-e89b-12d3-a456-426614174000"],
     )
 
+    @computed_field(json_schema_extra={"deprecated": True})
+    def success(self) -> bool:
+        """Successful response flag."""
+        logger.warning("DEPRECATED: Will be removed in a future release.")
+        return True
+
     model_config = {
         "json_schema_extra": {
             "examples": [