Merge pull request lightspeed-core#976 from tisnik/lcore-1051-optional-types-in-tests

LCORE-1051: optional types in tests

Author: tisnik

tests/e2e/features/steps/feedback.py

@@ -1,5 +1,7 @@
 """Implementation of common test steps for the feedback API."""
 
+from typing import Optional
+
 from behave import given, when, step  # pyright: ignore[reportAttributeAccessIssue]
 from behave.runner import Context
 import requests
@@ -71,7 +73,7 @@ def submit_feedback_without_conversation(context: Context) -> None:
 
 
 def access_feedback_post_endpoint(
-    context: Context, conversation_id: str | None
+    context: Context, conversation_id: Optional[str]
 ) -> None:
     """Send POST HTTP request with JSON payload to tested service."""
     endpoint = "feedback"

tests/unit/cache/test_noop_cache.py

@@ -1,5 +1,7 @@
 """Unit tests for NoopCache class."""
 
+from typing import Optional
+
 import pytest
 
 from models.cache_entry import CacheEntry
@@ -198,21 +200,21 @@ def test_ready(cache_fixture: NoopCache) -> None:
 
 
 @pytest.mark.parametrize("uuid", improper_user_uuids)
-def test_list_improper_user_id(cache_fixture: NoopCache, uuid: str | None) -> None:
+def test_list_improper_user_id(cache_fixture: NoopCache, uuid: Optional[str]) -> None:
     """Test list with invalid user ID."""
     with pytest.raises(ValueError, match=f"Invalid user ID {uuid}"):
         cache_fixture.list(uuid)
 
 
 @pytest.mark.parametrize("uuid", improper_user_uuids)
-def test_delete_improper_user_id(cache_fixture: NoopCache, uuid: str | None) -> None:
+def test_delete_improper_user_id(cache_fixture: NoopCache, uuid: Optional[str]) -> None:
     """Test delete with invalid user ID."""
     with pytest.raises(ValueError, match=f"Invalid user ID {uuid}"):
         cache_fixture.delete(uuid, CONVERSATION_ID)
 
 
 @pytest.mark.parametrize("uuid", improper_user_uuids)
-def test_get_improper_user_id(cache_fixture: NoopCache, uuid: str | None) -> None:
+def test_get_improper_user_id(cache_fixture: NoopCache, uuid: Optional[str]) -> None:
     """Test how improper user ID is handled."""
     with pytest.raises(ValueError, match=f"Invalid user ID {uuid}"):
         cache_fixture.get(uuid, CONVERSATION_ID)

tests/unit/models/rlsapi/test_requests.py

@@ -1,7 +1,7 @@
 # pylint: disable=no-member
 """Unit tests for rlsapi v1 request models."""
 
-from typing import Any
+from typing import Any, Optional
 
 import pytest
 from pydantic import BaseModel, ValidationError
@@ -269,7 +269,9 @@ def test_constructor_full(self, sample_request: RlsapiV1InferRequest) -> None:
             ),
         ],
     )
-    def test_question_validation(self, question: str | None, error_match: str) -> None:
+    def test_question_validation(
+        self, question: Optional[str], error_match: str
+    ) -> None:
         """Test question field validation for various invalid inputs."""
         with pytest.raises(ValidationError, match=error_match):
             if question is None:

tests/unit/utils/test_responses.py

@@ -1,15 +1,15 @@
 """Unit tests for utils/responses.py functions."""
 
 from types import SimpleNamespace
-from typing import Any
+from typing import Any, Optional
 
 import pytest
 
 from utils.responses import extract_text_from_response_output_item
 
 
 def make_output_item(
-    item_type: str | None = None, role: str | None = None, content: Any = None
+    item_type: Optional[str] = None, role: Optional[str] = None, content: Any = None
 ) -> SimpleNamespace:
     """Create a mock Responses API output item.
 
@@ -25,7 +25,7 @@ def make_output_item(
 
 
 def make_content_part(
-    text: str | None = None, refusal: str | None = None
+    text: Optional[str] = None, refusal: Optional[str] = None
 ) -> SimpleNamespace:
     """Create a mock content part for message content.