Merge pull request lightspeed-core#2071 from Jdubrick/add-saved-prompt-config

RHIDP-14303: add config fields for saved prompts

Author: Jdubrick

docs/openapi.json

@@ -12223,6 +12223,11 @@
                         ],
                         "title": "Agent skills",
                         "description": "Agent skills configuration. Specifies paths to skill directories."
+                    },
+                    "saved_prompts": {
+                        "$ref": "#/components/schemas/SavedPromptsConfiguration",
+                        "title": "Saved prompts configuration",
+                        "description": "Configuration for saved prompts feature limits including maximum prompts per user, display name length, and content length."
                     }
                 },
                 "additionalProperties": false,
@@ -19266,6 +19271,53 @@
                 "title": "SQLiteDatabaseConfiguration",
                 "description": "SQLite database configuration."
             },
+            "SavedPromptsConfiguration": {
+                "properties": {
+                    "max_prompts_per_user": {
+                        "anyOf": [
+                            {
+                                "type": "integer",
+                                "exclusiveMinimum": 0.0
+                            },
+                            {
+                                "type": "null"
+                            }
+                        ],
+                        "title": "Max prompts per user",
+                        "description": "Maximum number of saved prompts a user can create. Defaults to 50. Cannot exceed 200."
+                    },
+                    "max_display_name_length": {
+                        "anyOf": [
+                            {
+                                "type": "integer",
+                                "exclusiveMinimum": 0.0
+                            },
+                            {
+                                "type": "null"
+                            }
+                        ],
+                        "title": "Max display name length",
+                        "description": "Maximum character length for prompt display name (title). Defaults to 255. Cannot exceed 255."
+                    },
+                    "max_content_length": {
+                        "anyOf": [
+                            {
+                                "type": "integer",
+                                "exclusiveMinimum": 0.0
+                            },
+                            {
+                                "type": "null"
+                            }
+                        ],
+                        "title": "Max content length",
+                        "description": "Maximum character length for the prompt content body. Defaults to 10000. Cannot exceed 30000."
+                    }
+                },
+                "additionalProperties": false,
+                "type": "object",
+                "title": "SavedPromptsConfiguration",
+                "description": "Configuration for saved prompts feature limits.\n\nControls the maximum number of prompts a user can save, the maximum\ndisplay name (title) length, and the maximum prompt content length.\nAll fields are optional and default to values defined in constants.\n\nAttributes:\n    max_prompts_per_user: Maximum number of saved prompts allowed per user.\n    max_display_name_length: Maximum character length for the prompt display name.\n    max_content_length: Maximum character length for the prompt content body."
+            },
             "SearchRankingOptions": {
                 "properties": {
                     "ranker": {

src/constants.py

@@ -351,3 +351,15 @@
 # first version check.
 DEFAULT_MAX_RETRIES: Final[int] = 5
 DEFAULT_RETRY_DELAY: Final[int] = 2
+
+# Saved prompts configuration defaults and upper bounds.
+# Defaults are used when a field is omitted from lightspeed-stack.yaml.
+# Upper bounds prevent operators from exceeding DB or application limits.
+SAVED_PROMPTS_DEFAULT_MAX_PER_USER: Final[int] = 50
+SAVED_PROMPTS_MAX_PER_USER_UPPER_BOUND: Final[int] = 200
+SAVED_PROMPTS_DEFAULT_MAX_DISPLAY_NAME_LENGTH: Final[int] = 255  # database column limit
+SAVED_PROMPTS_MAX_DISPLAY_NAME_LENGTH_UPPER_BOUND: Final[int] = (
+    255  # database column limit
+)
+SAVED_PROMPTS_DEFAULT_MAX_CONTENT_LENGTH: Final[int] = 10_000
+SAVED_PROMPTS_MAX_CONTENT_LENGTH_UPPER_BOUND: Final[int] = 30_000

src/models/config.py

@@ -2330,6 +2330,108 @@ class SkillsConfiguration(ConfigurationBase):
     )
 
 
+class SavedPromptsConfiguration(ConfigurationBase):
+    """Configuration for saved prompts feature limits.
+
+    Controls the maximum number of prompts a user can save, the maximum
+    display name (title) length, and the maximum prompt content length.
+    All fields are optional and default to values defined in constants.
+
+    Attributes:
+        max_prompts_per_user: Maximum number of saved prompts allowed per user.
+        max_display_name_length: Maximum character length for the prompt display name.
+        max_content_length: Maximum character length for the prompt content body.
+    """
+
+    max_prompts_per_user: Optional[PositiveInt] = Field(
+        default=None,
+        title="Max prompts per user",
+        description="Maximum number of saved prompts a user can create. "
+        f"Defaults to {constants.SAVED_PROMPTS_DEFAULT_MAX_PER_USER}. "
+        f"Cannot exceed {constants.SAVED_PROMPTS_MAX_PER_USER_UPPER_BOUND}.",
+    )
+
+    max_display_name_length: Optional[PositiveInt] = Field(
+        default=None,
+        title="Max display name length",
+        description="Maximum character length for prompt display name (title). "
+        f"Defaults to {constants.SAVED_PROMPTS_DEFAULT_MAX_DISPLAY_NAME_LENGTH}. "
+        f"Cannot exceed {constants.SAVED_PROMPTS_MAX_DISPLAY_NAME_LENGTH_UPPER_BOUND}.",
+    )
+
+    max_content_length: Optional[PositiveInt] = Field(
+        default=None,
+        title="Max content length",
+        description="Maximum character length for the prompt content body. "
+        f"Defaults to {constants.SAVED_PROMPTS_DEFAULT_MAX_CONTENT_LENGTH}. "
+        f"Cannot exceed {constants.SAVED_PROMPTS_MAX_CONTENT_LENGTH_UPPER_BOUND}.",
+    )
+
+    @model_validator(mode="after")
+    def apply_defaults_and_validate_bounds(self) -> Self:
+        """Apply default values for None fields and validate upper bounds.
+
+        Logs an info message for each field that falls back to its default.
+
+        Returns:
+            Self: The validated model instance with defaults applied.
+
+        Raises:
+            ValueError: If any value exceeds its upper bound.
+        """
+        if self.max_prompts_per_user is None:
+            self.max_prompts_per_user = constants.SAVED_PROMPTS_DEFAULT_MAX_PER_USER
+            logger.info(
+                "saved_prompts.max_prompts_per_user not configured, "
+                "using default: %d",
+                constants.SAVED_PROMPTS_DEFAULT_MAX_PER_USER,
+            )
+        elif (
+            self.max_prompts_per_user > constants.SAVED_PROMPTS_MAX_PER_USER_UPPER_BOUND
+        ):
+            raise ValueError(
+                f"max_prompts_per_user ({self.max_prompts_per_user}) exceeds "
+                f"upper bound ({constants.SAVED_PROMPTS_MAX_PER_USER_UPPER_BOUND})."
+            )
+
+        if self.max_display_name_length is None:
+            self.max_display_name_length = (
+                constants.SAVED_PROMPTS_DEFAULT_MAX_DISPLAY_NAME_LENGTH
+            )
+            logger.info(
+                "saved_prompts.max_display_name_length not configured, "
+                "using default: %d",
+                constants.SAVED_PROMPTS_DEFAULT_MAX_DISPLAY_NAME_LENGTH,
+            )
+        elif (
+            self.max_display_name_length
+            > constants.SAVED_PROMPTS_MAX_DISPLAY_NAME_LENGTH_UPPER_BOUND
+        ):
+            raise ValueError(
+                f"max_display_name_length ({self.max_display_name_length}) exceeds "
+                f"database column limit "
+                f"({constants.SAVED_PROMPTS_MAX_DISPLAY_NAME_LENGTH_UPPER_BOUND})."
+            )
+
+        if self.max_content_length is None:
+            self.max_content_length = constants.SAVED_PROMPTS_DEFAULT_MAX_CONTENT_LENGTH
+            logger.info(
+                "saved_prompts.max_content_length not configured, "
+                + "using default: %d",
+                constants.SAVED_PROMPTS_DEFAULT_MAX_CONTENT_LENGTH,
+            )
+        elif (
+            self.max_content_length
+            > constants.SAVED_PROMPTS_MAX_CONTENT_LENGTH_UPPER_BOUND
+        ):
+            raise ValueError(
+                f"max_content_length ({self.max_content_length}) exceeds "
+                f"upper bound ({constants.SAVED_PROMPTS_MAX_CONTENT_LENGTH_UPPER_BOUND})."
+            )
+
+        return self
+
+
 class QuestionValidityConfig(ConfigurationBase):
     """Configuration for the question validity guardrail."""
 
@@ -2622,6 +2724,13 @@ class Configuration(ConfigurationBase):
         description="Agent skills configuration. Specifies paths to skill directories.",
     )
 
+    saved_prompts: SavedPromptsConfiguration = Field(
+        default_factory=SavedPromptsConfiguration,
+        title="Saved prompts configuration",
+        description="Configuration for saved prompts feature limits including "
+        "maximum prompts per user, display name length, and content length.",
+    )
+
     @model_validator(mode="after")
     def validate_mcp_auth_headers(self) -> Self:
         """

tests/unit/models/config/test_dump_configuration.py

@@ -34,6 +34,12 @@
     "approval_retention_days": 30,
 }
 
+_DEFAULT_SAVED_PROMPTS_DUMP: dict[str, int] = {
+    "max_prompts_per_user": constants.SAVED_PROMPTS_DEFAULT_MAX_PER_USER,
+    "max_display_name_length": constants.SAVED_PROMPTS_DEFAULT_MAX_DISPLAY_NAME_LENGTH,
+    "max_content_length": constants.SAVED_PROMPTS_DEFAULT_MAX_CONTENT_LENGTH,
+}
+
 _MCP_SERVER_DUMP_DEFAULTS: dict[str, Any] = {
     "authorization_headers": {},
     "headers": [],
@@ -223,6 +229,7 @@ def test_dump_configuration_minimal_cfg(tmp_path: Path) -> None:
                 "enabled": False,
                 "model": "cross-encoder/ms-marco-MiniLM-L6-v2",
             },
+            "saved_prompts": _DEFAULT_SAVED_PROMPTS_DUMP,
             "skills": None,
         }
 
@@ -445,6 +452,7 @@ def test_dump_configuration_valid_values(tmp_path: Path) -> None:
                 "enabled": False,
                 "model": "cross-encoder/ms-marco-MiniLM-L6-v2",
             },
+            "saved_prompts": _DEFAULT_SAVED_PROMPTS_DUMP,
             "skills": None,
         }
 
@@ -818,6 +826,7 @@ def test_dump_configuration_with_quota_limiters(tmp_path: Path) -> None:
                 "enabled": False,
                 "model": "cross-encoder/ms-marco-MiniLM-L6-v2",
             },
+            "saved_prompts": _DEFAULT_SAVED_PROMPTS_DUMP,
             "skills": None,
         }
 
@@ -1075,6 +1084,7 @@ def test_dump_configuration_with_quota_limiters_different_values(
                 "enabled": False,
                 "model": "cross-encoder/ms-marco-MiniLM-L6-v2",
             },
+            "saved_prompts": _DEFAULT_SAVED_PROMPTS_DUMP,
             "skills": None,
         }
 
@@ -1312,6 +1322,7 @@ def test_dump_configuration_byok(tmp_path: Path) -> None:
                 "enabled": False,
                 "model": "cross-encoder/ms-marco-MiniLM-L6-v2",
             },
+            "saved_prompts": _DEFAULT_SAVED_PROMPTS_DUMP,
             "skills": None,
         }
 
@@ -1529,6 +1540,7 @@ def test_dump_configuration_pg_namespace(tmp_path: Path) -> None:
                 "enabled": False,
                 "model": "cross-encoder/ms-marco-MiniLM-L6-v2",
             },
+            "saved_prompts": _DEFAULT_SAVED_PROMPTS_DUMP,
             "skills": None,
         }
 
@@ -1906,6 +1918,7 @@ def test_dump_configuration_allow_degraded_mode(tmp_path: Path) -> None:
                 "enabled": False,
                 "model": "cross-encoder/ms-marco-MiniLM-L6-v2",
             },
+            "saved_prompts": _DEFAULT_SAVED_PROMPTS_DUMP,
             "skills": None,
         }
 
@@ -2129,6 +2142,7 @@ def test_dump_configuration_max_retries_settings(tmp_path: Path) -> None:
                 "enabled": False,
                 "model": "cross-encoder/ms-marco-MiniLM-L6-v2",
             },
+            "saved_prompts": _DEFAULT_SAVED_PROMPTS_DUMP,
             "skills": None,
         }
 
@@ -2352,6 +2366,7 @@ def test_dump_configuration_retry_count_settings(tmp_path: Path) -> None:
                 "enabled": False,
                 "model": "cross-encoder/ms-marco-MiniLM-L6-v2",
             },
+            "saved_prompts": _DEFAULT_SAVED_PROMPTS_DUMP,
             "skills": None,
         }
 
@@ -2582,5 +2597,6 @@ def test_dump_configuration_specific_compaction_values(tmp_path: Path) -> None:
                 "enabled": False,
                 "model": "cross-encoder/ms-marco-MiniLM-L6-v2",
             },
+            "saved_prompts": _DEFAULT_SAVED_PROMPTS_DUMP,
             "skills": None,
         }