Refactored unit tests for JWTRoleRule and LlamaStackConfiguration models

Author: tisnik

tests/unit/models/config/test_jwt_role_rule.py

@@ -0,0 +1,119 @@
+"""Unit tests for JwtRoleRule model."""
+
+import pytest
+
+from pydantic import ValidationError
+
+from models.config import JwtRoleRule, JsonPathOperator
+
+
+def test_jwt_role_rule_missing_attributes() -> None:
+    """Check the JwtRoleRule config class."""
+    with pytest.raises(ValidationError, match="validation errors"):
+        _ = JwtRoleRule()
+
+
+def test_jwt_role_rule_correct_attributes() -> None:
+    """Check the JwtRoleRule config class."""
+    r = JwtRoleRule(
+        jsonpath="$.id",
+        negate=False,
+        value="xyz",
+        roles=["admin"],
+        operator=JsonPathOperator.EQUALS,
+    )
+
+    assert r is not None
+    assert r.compiled_regex is None
+
+
+def test_jwt_role_rule_invalid_json_path() -> None:
+    """Check the JwtRoleRule config class."""
+    with pytest.raises(ValidationError, match="Invalid JSONPath expression"):
+        _ = JwtRoleRule(
+            jsonpath="this/is/not/valid",
+            negate=False,
+            value="xyz",
+            roles=["admin"],
+            operator=JsonPathOperator.EQUALS,
+        )
+
+
+def test_jwt_role_rule_no_roles_specified() -> None:
+    """Check the JwtRoleRule config class."""
+    with pytest.raises(
+        ValidationError, match="At least one role must be specified in the rule"
+    ):
+        _ = JwtRoleRule(
+            jsonpath="$.id",
+            negate=False,
+            value="xyz",
+            roles=[],
+            operator=JsonPathOperator.EQUALS,
+        )
+
+
+def test_jwt_role_rule_star_role_specified() -> None:
+    """Check the JwtRoleRule config class."""
+    with pytest.raises(
+        ValidationError, match="The wildcard '\\*' role is not allowed in role rules"
+    ):
+        _ = JwtRoleRule(
+            jsonpath="$.id",
+            negate=False,
+            value="xyz",
+            roles=["*"],
+            operator=JsonPathOperator.EQUALS,
+        )
+
+
+def test_jwt_role_rule_same_roles() -> None:
+    """Check the JwtRoleRule config class."""
+    with pytest.raises(ValidationError, match="Roles must be unique in the rule"):
+        _ = JwtRoleRule(
+            jsonpath="$.id",
+            negate=False,
+            value="xyz",
+            roles=["admin", "admin", "user"],
+            operator=JsonPathOperator.EQUALS,
+        )
+
+
+def test_jwt_role_rule_invalid_value() -> None:
+    """Check the JwtRoleRule config class."""
+    with pytest.raises(
+        ValidationError, match="MATCH operator requires a string pattern"
+    ):
+        _ = JwtRoleRule(
+            jsonpath="$.id",
+            negate=False,
+            value=True,  # not a string
+            roles=["admin", "user"],
+            operator=JsonPathOperator.MATCH,
+        )
+
+
+def test_jwt_role_rule_valid_regexp() -> None:
+    """Check the JwtRoleRule config class."""
+    j = JwtRoleRule(
+        jsonpath="$.id",
+        negate=False,
+        value=".*",  # valid regexp
+        roles=["admin", "user"],
+        operator=JsonPathOperator.MATCH,
+    )
+    assert j.compiled_regex is not None
+
+
+def test_jwt_role_rule_invalid_regexp() -> None:
+    """Check the JwtRoleRule config class."""
+    with pytest.raises(
+        ValidationError, match="Invalid regex pattern for MATCH operator"
+    ):
+        _ = JwtRoleRule(
+            jsonpath="$.id",
+            negate=False,
+            value="[[[",  # invalid regexp
+            roles=["admin", "user"],
+            operator=JsonPathOperator.MATCH,
+        )

tests/unit/models/config/test_llama_stack_configuration.py

@@ -0,0 +1,78 @@
+"""Unit tests for LlamaStackConfiguration model."""
+
+import pytest
+
+from utils.checks import InvalidConfigurationError
+
+from models.config import LlamaStackConfiguration
+
+
+def test_llama_stack_configuration_constructor() -> None:
+    """
+    Verify that the LlamaStackConfiguration constructor accepts
+    valid combinations of parameters and creates instances
+    successfully.
+    """
+    llama_stack_configuration = LlamaStackConfiguration(
+        use_as_library_client=True,
+        library_client_config_path="tests/configuration/run.yaml",
+    )
+    assert llama_stack_configuration is not None
+
+    llama_stack_configuration = LlamaStackConfiguration(
+        use_as_library_client=False, url="http://localhost"
+    )
+    assert llama_stack_configuration is not None
+
+    llama_stack_configuration = LlamaStackConfiguration(url="http://localhost")
+    assert llama_stack_configuration is not None
+
+    llama_stack_configuration = LlamaStackConfiguration(
+        use_as_library_client=False, url="http://localhost", api_key="foo"
+    )
+    assert llama_stack_configuration is not None
+
+
+def test_llama_stack_configuration_no_run_yaml() -> None:
+    """
+    Verify that constructing a LlamaStackConfiguration with a
+    non-existent or invalid library_client_config_path raises
+    InvalidConfigurationError.
+    """
+    with pytest.raises(
+        InvalidConfigurationError,
+        match="Llama Stack configuration file 'not a file' is not a file",
+    ):
+        LlamaStackConfiguration(
+            use_as_library_client=True,
+            library_client_config_path="not a file",
+        )
+
+
+def test_llama_stack_wrong_configuration_constructor_no_url() -> None:
+    """
+    Verify that constructing a LlamaStackConfiguration without
+    specifying either a URL or enabling library client mode raises
+    a ValueError.
+    """
+    with pytest.raises(
+        ValueError,
+        match="Llama stack URL is not specified and library client mode is not specified",
+    ):
+        LlamaStackConfiguration()
+
+
+def test_llama_stack_wrong_configuration_constructor_library_mode_off() -> None:
+    """Test the LlamaStackConfiguration constructor."""
+    with pytest.raises(
+        ValueError,
+        match="Llama stack URL is not specified and library client mode is not enabled",
+    ):
+        LlamaStackConfiguration(use_as_library_client=False)
+
+
+def test_llama_stack_wrong_configuration_no_config_file() -> None:
+    """Test the LlamaStackConfiguration constructor."""
+    m = "Llama stack library client mode is enabled but a configuration file path is not specified"
+    with pytest.raises(ValueError, match=m):
+        LlamaStackConfiguration(use_as_library_client=True)

tests/unit/models/config/test_postgresql_database_configuration.py

@@ -0,0 +1,74 @@
+"""Unit tests for PostgreSQLDatabaseConfiguration model."""
+
+from pathlib import Path
+
+import pytest
+
+from pydantic import ValidationError
+
+from constants import (
+    POSTGRES_DEFAULT_SSL_MODE,
+    POSTGRES_DEFAULT_GSS_ENCMODE,
+)
+
+from models.config import PostgreSQLDatabaseConfiguration
+
+
+def test_postgresql_database_configuration() -> None:
+    """Test the PostgreSQLDatabaseConfiguration model."""
+    c = PostgreSQLDatabaseConfiguration(db="db", user="user", password="password")
+    assert c is not None
+    assert c.host == "localhost"
+    assert c.port == 5432
+    assert c.db == "db"
+    assert c.user == "user"
+    assert c.password.get_secret_value() == "password"
+    assert c.ssl_mode == POSTGRES_DEFAULT_SSL_MODE
+    assert c.gss_encmode == POSTGRES_DEFAULT_GSS_ENCMODE
+    assert c.namespace == "lightspeed-stack"
+    assert c.ca_cert_path is None
+
+
+def test_postgresql_database_configuration_port_setting(subtests) -> None:
+    """Test the PostgreSQLDatabaseConfiguration model."""
+    with subtests.test(msg="Correct port value"):
+        c = PostgreSQLDatabaseConfiguration(
+            db="db", user="user", password="password", port=1234
+        )
+        assert c is not None
+        assert c.port == 1234
+
+    with subtests.test(msg="Negative port value"):
+        with pytest.raises(ValidationError, match="Input should be greater than 0"):
+            PostgreSQLDatabaseConfiguration(
+                db="db", user="user", password="password", port=-1
+            )
+
+    with subtests.test(msg="Too big port value"):
+        with pytest.raises(ValueError, match="Port value should be less than 65536"):
+            PostgreSQLDatabaseConfiguration(
+                db="db", user="user", password="password", port=100000
+            )
+
+
+def test_postgresql_database_configuration_ca_cert_path(subtests) -> None:
+    """Test the PostgreSQLDatabaseConfiguration model."""
+    with subtests.test(msg="Path exists"):
+        c = PostgreSQLDatabaseConfiguration(
+            db="db",
+            user="user",
+            password="password",
+            port=1234,
+            ca_cert_path=Path("tests/configuration/server.crt"),
+        )
+        assert c.ca_cert_path == Path("tests/configuration/server.crt")
+
+    with subtests.test(msg="Path does not exist"):
+        with pytest.raises(ValidationError, match="Path does not point to a file"):
+            PostgreSQLDatabaseConfiguration(
+                db="db",
+                user="user",
+                password="password",
+                port=1234,
+                ca_cert_path=Path("not a file"),
+            )