TimMenu: fixed some bad code removed unnecesary liabilities

Author: titaniummachine1

TimMenu/Common.lua

@@ -1,4 +1,3 @@
----@diagnostic disable: duplicate-set-field
 local Utils = require("TimMenu.Utils")
 local Globals = require("TimMenu.Globals")
 
@@ -236,12 +235,12 @@ local function OnUnload()
 	input.SetMouseInputEnabled(false)
 	Utils.PruneOrphanedWindows(TimMenuGlobal.windows, TimMenuGlobal.order)
 	print("Unloading TimMenu")
+	-- Unregister callbacks to prevent conflicts on reload
+	callbacks.Unregister("Draw", "zTimMenu_GlobalDraw")
 	package.loaded["TimMenu"] = nil
 end
 
 callbacks.Unregister("Unload", "TimMenu_Unload")
 callbacks.Register("Unload", "TimMenu_Unload", OnUnload)
 
--- Monkey patch draw functions to ensure all draw positions are integers-- This prevents floating point coordinates which can cause rendering issuesdo	local origFilled = draw.FilledRect	---@diagnostic disable-next-line: duplicate-set-field	draw.FilledRect = function(x1, y1, x2, y2)		origFilled(math.floor(x1), math.floor(y1), math.floor(x2), math.floor(y2))	end	local origOutlined = draw.OutlinedRect	---@diagnostic disable-next-line: duplicate-set-field	draw.OutlinedRect = function(x1, y1, x2, y2)		origOutlined(math.floor(x1), math.floor(y1), math.floor(x2), math.floor(y2))	end	local origLine = draw.Line	if origLine then		---@diagnostic disable-next-line: duplicate-set-field		draw.Line = function(x1, y1, x2, y2)			origLine(math.floor(x1), math.floor(y1), math.floor(x2), math.floor(y2))		end	end	local origText = draw.Text	---@diagnostic disable-next-line: duplicate-set-field	draw.Text = function(x, y, text)		origText(math.floor(x), math.floor(y), text)	end	local origTextured = draw.TexturedRect	if origTextured then		---@diagnostic disable-next-line: duplicate-set-field		draw.TexturedRect = function(id, x1, y1, x2, y2)			origTextured(id, math.floor(x1), math.floor(y1), math.floor(x2), math.floor(y2))		end	endend
-
 return Common

TimMenu/Main.lua

@@ -44,7 +44,7 @@ end
 
 local function withFontReset(func, ...)
 	local prevFont = applyNextWidgetFont()
-	local results = {func(...)}
+	local results = { func(...) }
 	restoreWidgetFont(prevFont)
 	return table.unpack(results)
 end
@@ -357,13 +357,8 @@ local function _TimMenu_GlobalDraw()
 	end
 end
 
-callbacks.Unregister("Draw", "TimMenu_GlobalDraw")
-callbacks.Unregister("Draw", "zTimMenu_GlobalDraw")
 callbacks.Register("Draw", "zTimMenu_GlobalDraw", _TimMenu_GlobalDraw)
 
--- Textbox is deprecated, use TextInput instead
-TimMenu.Textbox = TimMenu.TextInput
-
 function TimMenu.Keybind(label, currentKey)
 	local win = TimMenu.GetCurrentWindow()
 	if not win then

TimMenu/Utils.lua

@@ -15,7 +15,7 @@ function Utils.PruneOrphanedWindows(windows, order)
 	end
 end
 
-function Utils.IsMouseOverWindow(win, mouseX, mouseY, titleHeight)
+function Utils.IsMouseOverWindow(win, mouseX, mouseY)
 	local titleHeight = require("TimMenu.Globals").Defaults.TITLE_BAR_HEIGHT
 	return mouseX >= win.X and mouseX <= win.X + win.W and mouseY >= win.Y and mouseY <= win.Y + titleHeight + win.H
 end